feat(cors): add Vary: Origin header for dynamic origin responses#170
Merged
Conversation
|
@Utkarsh0uchiha is attempting to deploy a commit to the Devanshu Tripathi's projects Team on Vercel. A member of the Team first needs to authorize it. |
DevanshuTripathi
added
level:intermediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150
Summary
This PR adds the
Vary: Originresponse header whenever the CORS middleware dynamically setsAccess-Control-Allow-Origin.Added
Vary: Originheader for dynamic origin responsesMotivation
The CORS middleware currently varies its response based on the incoming
Originheader:Access-Control-Allow-Origin: <request-origin>