feat: add MaxAge preflight cache support to AllowCORS#140
Merged
DevanshuTripathi merged 2 commits intoJun 15, 2026
Conversation
|
@ghosthouse7 is attempting to deploy a commit to the Devanshu Tripathi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@ghosthouse7 Can you write tests for it |
Contributor
Author
|
def! just give me some time |
Owner
|
Hi @ghosthouse7 Just checking to see if you are active on this PR |
Contributor
Author
|
yeah yeah on it, will be raising a pr very soon. |
Contributor
Author
|
Hey @DevanshuTripathi, added the tests! Here's what's covered: TestCORSAllowsMaxAge — verifies MaxAge: 86400 sets the header correctly on preflight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #125
Changes
on preflight OPTIONS responses
Usage
// Basic usage (unchanged)
app.Use(AllowCORS([]string{"*"}))
// With MaxAge preflight caching
app.Use(AllowCORS([]string{"*"}, vodka.CORSConfig{
MaxAge: 86400, // cache preflight for 24 hours
}))
Why This Matters
on every single API call
response and skip redundant requests
Files Changed