feat: support multiple flakes#204
Open
fym998 wants to merge 4 commits intoDeterminateSystems:mainfrom
Open
Conversation
Author
|
@cole-h make a review please 🙏 |
|
I've been using this PR version of the action for a while, and the only thing that bothers me is that I am not able to set different commit messages for each flake. Can you add this functionality? |
Author
Thanks for feedback! See fym998/update-flake-lock@commit-summary-per-flake Example: - uses: fym998/update-flake-lock@commit-summary-per-flake
with:
flakes: |
.
sub-flake/
sub-flake-empty-commit-summary/
sub-flake-null-commit-summary/
sub-flake-not-listed/
commit-msg: default commit summary message
commit-msg-per-flake: |
{
".": "Update flake.lock for main flake",
"sub-flake/": "Update flake.lock for sub-flake",
"sub-flake-empty-commit-summary/": "",
"sub-flake-null-commit-summary/": null
} |
|
Cool, why not just use something like: - uses: fym998/update-flake-lock@commit-summary-per-flake
with:
flakes: |
.
sub-flake/
sub-flake-empty-commit-summary/
sub-flake-null-commit-summary/
sub-flake-not-listed/
commit-msg: |
Update flake.lock for main flake
Update flake.lock for sub-flake
''instead? I think its a better ux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to #109 , but simpler. Use
nix flake update --flake <dir>to handle flakes. Tested here: fym998/update-flake-lock-test-template/pull/1.Checklist