Skip to content

add back project view tool window#146

Merged
DetachHead merged 5 commits intoDetachHead:masterfrom
mchades:feature/add-project-view
May 10, 2026
Merged

add back project view tool window#146
DetachHead merged 5 commits intoDetachHead:masterfrom
mchades:feature/add-project-view

Conversation

@mchades
Copy link
Copy Markdown

@mchades mchades commented Apr 17, 2026

Resolves #129

Re-enables the Project tool window that was previously removed.

Key behavior:

  • The project view is available via the tool window button on the left sidebar
  • doNotActivateOnStart="true" ensures it does not open automatically on startup — the commit tool window remains the default view
  • No additional project indexing or smart features are introduced; the factory class is the standard file tree view

Unlike IntelliJ, the project view is not shown by default on startup.
The commit tool window remains the default view.

Closes DetachHead#129

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Owner

@DetachHead DetachHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment thread platform/platform-resources/src/META-INF/LangExtensions.xml Outdated
Comment thread platform/platform-resources/src/META-INF/LangExtensions.xml Outdated
mchades and others added 2 commits April 18, 2026 22:44
- Add secondary="true" to Project tool window so it appears below
  git-related tool windows in the left sidebar
- Comment out ScopeViewPane registration (not needed for a git-focused IDE)
- Comment out PackageViewPane registration (Java-specific, not needed)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- make Project default to split section in new UI layout so it stays below primary Git windows
- migrate existing new UI layouts to keep Project in split section
- skip startup auto-activation when Project tool window is marked doNotActivateOnStart
- add regression tests for layout migration and startup activation guard

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Owner

@DetachHead DetachHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for the delay, i've been having a LOT of trouble getting the project to build locally for the past few days, so it's difficult for me to even test this myself. i also noticed you used copilot in this PR, which is fine, but i just have a few questions to make sure i'm not merging code that neither of us understand

also are you able to fix the failing CI so i can download the built artifacts and test it that way?

Comment thread java/java-backend/resources/META-INF/JavaPlugin.xml Outdated
Comment thread platform/platform-resources/src/META-INF/LangExtensions.xml
- Disable 'ide.open.project.view.on.startup' registry key by default
  instead of adding new gating logic in IdeProjectFrameAllocator.
- Revert the saved-layout migration in ToolWindowDefaultLayoutManager;
  rely on the new default layout (isSplit=true) only.
- Drop the IdeProjectFrameAllocatorTest (tautological tests; also
  caused CI failure since intellij.platform.ide.impl has no JUnit dep).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mchades
Copy link
Copy Markdown
Author

mchades commented Apr 30, 2026

Pushed cd39996 which addresses the review and significantly refocuses the PR (now 5 files / +12 / −7 vs master).

I want to be upfront: I'm not very familiar with this codebase, and after your first round of review I leaned heavily on Copilot to chase the layout/activation regression. That's how the PR ended up with the IdeProjectFrameAllocator changes, the saved-layout migration, and that (basically tautological) test — none of which I could justify on my own when you pushed back. Apologies for the noise. The new commit reverts all of that and goes with the much simpler approach you suggested.

Specifically:

  • Flipped the default of ide.open.project.view.on.startup to false in registry.properties instead of changing logic in IdeProjectFrameAllocator.kt (reverted).
  • Reverted the saved-layout migration in ToolWindowDefaultLayoutManager.kt; placement now relies solely on isSplit = true in the New UI default layout.
  • Deleted IdeProjectFrameAllocatorTest.kt. Bonus: that's also what was failing CI — the test was in intellij.platform.ide.impl, which doesn't have JUnit on its test classpath, so the build was failing on Unresolved reference 'junit'/'Test'. CI should be green now.

Inline replies left on the individual threads.

@stre4m
Copy link
Copy Markdown

stre4m commented May 9, 2026

We need this

@DetachHead
Copy link
Copy Markdown
Owner

be patient

@cookchen233
Copy link
Copy Markdown

Looking forward to the release

@DetachHead DetachHead merged commit b99c01d into DetachHead:master May 10, 2026
10 checks passed
DetachHead added a commit that referenced this pull request May 10, 2026
* add back project view tool window

Unlike IntelliJ, the project view is not shown by default on startup.
The commit tool window remains the default view.

Closes #129

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address PR review: reorder project view and remove unused panes

- Add secondary="true" to Project tool window so it appears below
  git-related tool windows in the left sidebar
- Comment out ScopeViewPane registration (not needed for a git-focused IDE)
- Comment out PackageViewPane registration (Java-specific, not needed)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix project toolwindow placement and startup activation

- make Project default to split section in new UI layout so it stays below primary Git windows
- migrate existing new UI layouts to keep Project in split section
- skip startup auto-activation when Project tool window is marked doNotActivateOnStart
- add regression tests for layout migration and startup activation guard

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address review: simplify project view startup handling

- Disable 'ide.open.project.view.on.startup' registry key by default
  instead of adding new gating logic in IdeProjectFrameAllocator.
- Revert the saved-layout migration in ToolWindowDefaultLayoutManager;
  rely on the new default layout (isSplit=true) only.
- Drop the IdeProjectFrameAllocatorTest (tautological tests; also
  caused CI failure since intellij.platform.ide.impl has no JUnit dep).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* revert commented out `projectViewPane` in `JavaPlugin.xml` because that plugin is disabled in rebased anyway

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: detachhead <detachhead@users.noreply.github.com>
(cherry picked from commit b99c01d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add back the project / files view

4 participants