add back project view tool window#146
Conversation
Unlike IntelliJ, the project view is not shown by default on startup. The commit tool window remains the default view. Closes DetachHead#129 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add secondary="true" to Project tool window so it appears below git-related tool windows in the left sidebar - Comment out ScopeViewPane registration (not needed for a git-focused IDE) - Comment out PackageViewPane registration (Java-specific, not needed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- make Project default to split section in new UI layout so it stays below primary Git windows - migrate existing new UI layouts to keep Project in split section - skip startup auto-activation when Project tool window is marked doNotActivateOnStart - add regression tests for layout migration and startup activation guard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DetachHead
left a comment
There was a problem hiding this comment.
apologies for the delay, i've been having a LOT of trouble getting the project to build locally for the past few days, so it's difficult for me to even test this myself. i also noticed you used copilot in this PR, which is fine, but i just have a few questions to make sure i'm not merging code that neither of us understand
also are you able to fix the failing CI so i can download the built artifacts and test it that way?
- Disable 'ide.open.project.view.on.startup' registry key by default instead of adding new gating logic in IdeProjectFrameAllocator. - Revert the saved-layout migration in ToolWindowDefaultLayoutManager; rely on the new default layout (isSplit=true) only. - Drop the IdeProjectFrameAllocatorTest (tautological tests; also caused CI failure since intellij.platform.ide.impl has no JUnit dep). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Pushed I want to be upfront: I'm not very familiar with this codebase, and after your first round of review I leaned heavily on Copilot to chase the layout/activation regression. That's how the PR ended up with the Specifically:
Inline replies left on the individual threads. |
|
We need this |
|
be patient |
…at plugin is disabled in rebased anyway
|
Looking forward to the release |
* add back project view tool window Unlike IntelliJ, the project view is not shown by default on startup. The commit tool window remains the default view. Closes #129 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * address PR review: reorder project view and remove unused panes - Add secondary="true" to Project tool window so it appears below git-related tool windows in the left sidebar - Comment out ScopeViewPane registration (not needed for a git-focused IDE) - Comment out PackageViewPane registration (Java-specific, not needed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix project toolwindow placement and startup activation - make Project default to split section in new UI layout so it stays below primary Git windows - migrate existing new UI layouts to keep Project in split section - skip startup auto-activation when Project tool window is marked doNotActivateOnStart - add regression tests for layout migration and startup activation guard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * address review: simplify project view startup handling - Disable 'ide.open.project.view.on.startup' registry key by default instead of adding new gating logic in IdeProjectFrameAllocator. - Revert the saved-layout migration in ToolWindowDefaultLayoutManager; rely on the new default layout (isSplit=true) only. - Drop the IdeProjectFrameAllocatorTest (tautological tests; also caused CI failure since intellij.platform.ide.impl has no JUnit dep). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * revert commented out `projectViewPane` in `JavaPlugin.xml` because that plugin is disabled in rebased anyway --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: detachhead <detachhead@users.noreply.github.com> (cherry picked from commit b99c01d)
Resolves #129
Re-enables the Project tool window that was previously removed.
Key behavior:
doNotActivateOnStart="true"ensures it does not open automatically on startup — the commit tool window remains the default view