Import backups without overwrite - #445
Open
jojoharry16 wants to merge 1 commit into
Open
Conversation
Owner
|
What you have makes sense! However there are more things that would need merging. For example, entries can have tag (the entry_tags table). The tags themselves would also likely need to get merged (the tag import feature already has this logic for reference). Setting that aside, I have UX concerns with this implementation. Restore implies replacement. This change makes it act more so as an import. |
Demizo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll be honest, I don't know what I'm doing and I'm sure whoever looks at this will know it smells off. I want this functionality in the app and here's the groundwork, any improvements or guidance would be greatly appreciated.