fix(api): gate x402 video quota before settlement - #104
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Anonymous x402 callers could pay for
video-generateafter their hourly video cap was already exhausted. The x402 middleware verified and settled payment before the route-levelvideoHourlyGateran, so the handler could return429 video_rate_limitedafter the payer had already been charged.Root cause
toolMiddleware("video-generate")runsx402Middlewarebefore the tool handler. The video hourly cap lived only in the handler, afterx402Paidwas set post-settlement.Fix
video-generatex402 pre-settlement quota gate after payment verification and before settlement.Validation
npm run buildnode tests/hardening-caps-audit.test.mjs