[BOUNTY ] Add GET /hello endpoint returning { ok: true }#124
Open
lequangsang01 wants to merge 2 commits into
Open
[BOUNTY ] Add GET /hello endpoint returning { ok: true }#124lequangsang01 wants to merge 2 commits into
lequangsang01 wants to merge 2 commits into
Conversation
Adds a simple hello-world test endpoint at GET /api/hello that
responds with { "ok": true } and HTTP 200.
Closes David-patrick-chuks#120
…-chuks#118, David-patrick-chuks#120) The /hello endpoint was mounted under /api but the bounty requires /hello. Moved it to app.ts and added a dedicated app-level test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /helloroute at app root that responds with HTTP 200 and{ "ok": true }/hello(not/api/hello) per the bounty specificationAcceptance Criteria
{ "ok": true }Changes
apps/api/src/app.ts:GET /helloroute handler returning{ ok: true }at the app root levelapps/api/src/app.test.ts:GET /helloreturns{ ok: true }with status 200apps/api/src/routes/api.ts:/helloroute (was at/api/hello)apps/api/src/routes/api.test.ts:/api/hellotest (moved to app.test.ts)Closes #118
Closes #120
/claim