Conversation
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate taegyunkim/check-redis (e51f2a2) with baseline main (d4f8802) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 105.797µs (SLO: <130.000µs 📉 -18.6%) vs baseline: +4.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 102.507µs (SLO: <130.000µs 📉 -21.1%) vs baseline: +0.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 28.187µs (SLO: <40.000µs 📉 -29.5%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 49.093µs (SLO: <70.000µs 📉 -29.9%) vs baseline: +1.0% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ bytearray_aspectTime: ✅ 250.748µs (SLO: <400.000µs 📉 -37.3%) vs baseline: -1.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 650.358µs (SLO: <800.000µs 📉 -18.7%) vs baseline: +0.8% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 268.151µs (SLO: <400.000µs 📉 -33.0%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 141.123µs (SLO: <300.000µs 📉 -53.0%) vs baseline: -0.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 221.365µs (SLO: <300.000µs 📉 -26.2%) vs baseline: -0.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 135.642µs (SLO: <200.000µs 📉 -32.2%) vs baseline: +1.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 3.883ms (SLO: <5.000ms 📉 -22.3%) vs baseline: +0.2% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 321.172µs (SLO: <420.000µs 📉 -23.5%) vs baseline: -0.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 88.223µs (SLO: <300.000µs 📉 -70.6%) vs baseline: -0.5% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ capitalize_noaspectTime: ✅ 261.698µs (SLO: <300.000µs 📉 -12.8%) vs baseline: +1.9% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 89.575µs (SLO: <500.000µs 📉 -82.1%) vs baseline: +1.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 310.147µs (SLO: <500.000µs 📉 -38.0%) vs baseline: -0.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ decode_aspectTime: ✅ 87.108µs (SLO: <100.000µs 📉 -12.9%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ decode_noaspectTime: ✅ 154.185µs (SLO: <210.000µs 📉 -26.6%) vs baseline: -0.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 85.218µs (SLO: <200.000µs 📉 -57.4%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 141.169µs (SLO: <200.000µs 📉 -29.4%) vs baseline: -0.8% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ format_aspectTime: ✅ 14.679ms (SLO: <19.200ms 📉 -23.5%) vs baseline: ~same Memory: ✅ 43.195MB (SLO: <46.000MB -6.1%) vs baseline: +5.3% ✅ format_map_aspectTime: ✅ 16.437ms (SLO: <21.500ms 📉 -23.5%) vs baseline: ~same Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 377.193µs (SLO: <500.000µs 📉 -24.6%) vs baseline: +0.3% Memory: ✅ 43.195MB (SLO: <46.000MB -6.1%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 305.827µs (SLO: <500.000µs 📉 -38.8%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 124.121µs (SLO: <300.000µs 📉 -58.6%) vs baseline: +3.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 40.850µs (SLO: <300.000µs 📉 -86.4%) vs baseline: +1.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 212.154µs (SLO: <300.000µs 📉 -29.3%) vs baseline: -0.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ join_noaspectTime: ✅ 140.721µs (SLO: <300.000µs 📉 -53.1%) vs baseline: -0.7% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ ljust_aspectTime: ✅ 605.390µs (SLO: <700.000µs 📉 -13.5%) vs baseline: 📈 +17.7% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ ljust_noaspectTime: ✅ 257.971µs (SLO: <300.000µs 📉 -14.0%) vs baseline: +0.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 295.472µs (SLO: <500.000µs 📉 -40.9%) vs baseline: +0.3% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 237.073µs (SLO: <300.000µs 📉 -21.0%) vs baseline: -0.3% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 0.278ms (SLO: <3.000ms 📉 -90.7%) vs baseline: +0.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.180ms (SLO: <3.000ms 📉 -94.0%) vs baseline: +0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ modulo_aspectTime: ✅ 14.356ms (SLO: <18.750ms 📉 -23.4%) vs baseline: ~same Memory: ✅ 43.175MB (SLO: <46.000MB -6.1%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.852ms (SLO: <19.350ms 📉 -23.2%) vs baseline: +0.1% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ modulo_aspect_for_bytesTime: ✅ 14.409ms (SLO: <18.900ms 📉 -23.8%) vs baseline: -0.3% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.614ms (SLO: <19.150ms 📉 -23.7%) vs baseline: -0.2% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 0.359ms (SLO: <3.000ms 📉 -88.0%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 18.501ms (SLO: <24.000ms 📉 -22.9%) vs baseline: +0.3% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 283.677µs (SLO: <300.000µs -5.4%) vs baseline: +1.2% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 314.801µs (SLO: <420.000µs 📉 -25.0%) vs baseline: +0.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 46.584µs (SLO: <90.000µs 📉 -48.2%) vs baseline: -0.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 391.753µs (SLO: <500.000µs 📉 -21.6%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 185.999µs (SLO: <300.000µs 📉 -38.0%) vs baseline: +0.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 183.810µs (SLO: <300.000µs 📉 -38.7%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 54.212µs (SLO: <90.000µs 📉 -39.8%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 4.524ms (SLO: <5.000ms -9.5%) vs baseline: 📈 +15.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 356.026µs (SLO: <500.000µs 📉 -28.8%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ strip_aspectTime: ✅ 278.345µs (SLO: <350.000µs 📉 -20.5%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ strip_noaspectTime: ✅ 178.931µs (SLO: <240.000µs 📉 -25.4%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 342.817µs (SLO: <500.000µs 📉 -31.4%) vs baseline: -0.2% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 276.531µs (SLO: <400.000µs 📉 -30.9%) vs baseline: -1.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 326.079µs (SLO: <500.000µs 📉 -34.8%) vs baseline: -0.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 265.422µs (SLO: <400.000µs 📉 -33.6%) vs baseline: -0.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 499.931µs (SLO: <700.000µs 📉 -28.6%) vs baseline: -0.8% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 428.991µs (SLO: <500.000µs 📉 -14.2%) vs baseline: -0.6% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 295.755µs (SLO: <500.000µs 📉 -40.8%) vs baseline: +0.5% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ upper_noaspectTime: ✅ 235.987µs (SLO: <400.000µs 📉 -41.0%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 509.148µs (SLO: <700.000µs 📉 -27.3%) vs baseline: 📈 +19.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 426.054µs (SLO: <700.000µs 📉 -39.1%) vs baseline: -1.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 616.365µs (SLO: <700.000µs 📉 -11.9%) vs baseline: -0.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 625.611µs (SLO: <700.000µs 📉 -10.6%) vs baseline: +0.3% Memory: ✅ 42.821MB (SLO: <46.000MB -6.9%) vs baseline: +5.3% ✅ ospathnormcase_aspectTime: ✅ 350.134µs (SLO: <700.000µs 📉 -50.0%) vs baseline: -0.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.2% ✅ ospathnormcase_noaspectTime: ✅ 358.189µs (SLO: <700.000µs 📉 -48.8%) vs baseline: +0.4% Memory: ✅ 42.703MB (SLO: <46.000MB -7.2%) vs baseline: +3.9% ✅ ospathsplit_aspectTime: ✅ 491.285µs (SLO: <700.000µs 📉 -29.8%) vs baseline: -0.1% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.9% ✅ ospathsplit_noaspectTime: ✅ 497.556µs (SLO: <700.000µs 📉 -28.9%) vs baseline: -0.1% Memory: ✅ 42.762MB (SLO: <46.000MB -7.0%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 371.199µs (SLO: <700.000µs 📉 -47.0%) vs baseline: -1.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.3% ✅ ospathsplitdrive_noaspectTime: ✅ 73.127µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 457.543µs (SLO: <700.000µs 📉 -34.6%) vs baseline: -0.6% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +6.1% ✅ ospathsplitext_noaspectTime: ✅ 465.047µs (SLO: <700.000µs 📉 -33.6%) vs baseline: +0.2% Memory: ✅ 42.841MB (SLO: <46.000MB -6.9%) vs baseline: +4.2% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.573µs (SLO: <20.000µs 📉 -82.1%) vs baseline: 📈 +14.4% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 208.440µs (SLO: <220.000µs -5.3%) vs baseline: -0.5% Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.430µs (SLO: <20.000µs 📉 -82.8%) vs baseline: ~same Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 221.677µs (SLO: <230.000µs -3.6%) vs baseline: -0.3% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.200µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.9% Memory: ✅ 35.645MB (SLO: <38.000MB -6.2%) vs baseline: +5.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.874µs (SLO: <150.000µs -9.4%) vs baseline: -0.8% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.233µs (SLO: <20.000µs 📉 -83.8%) vs baseline: -0.1% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 223.133µs (SLO: <250.000µs 📉 -10.7%) vs baseline: +0.4% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.260ms (SLO: <22.000ms -7.9%) vs baseline: -0.6% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.269ms (SLO: <2.550ms 📉 -11.0%) vs baseline: +1.0% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.399ms (SLO: <1.550ms -9.7%) vs baseline: +0.2% Memory: ✅ 35.645MB (SLO: <38.000MB -6.2%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.217ms (SLO: <2.550ms 📉 -13.1%) vs baseline: -0.3% Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.609µs (SLO: <20.000µs 📉 -77.0%) vs baseline: ~same Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 174.569µs (SLO: <250.000µs 📉 -30.2%) vs baseline: ~same Memory: ✅ 35.783MB (SLO: <38.000MB -5.8%) vs baseline: +5.4% ✅ flush-1000-metricsTime: ✅ 2.176ms (SLO: <2.500ms 📉 -13.0%) vs baseline: -0.2% Memory: ✅ 36.471MB (SLO: <38.750MB -5.9%) vs baseline: +4.9%
|
Description
Celery suite requires redis
dd-trace-py/tests/contrib/suitespec.yml
Line 490 in e51f2a2
And hence
waitvenv is run withredisarg, but we don't have wait check routine for redis inwait-for-services.pyhttps://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1402327713
With this PR,
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1402399458
Testing
Risks
Additional Notes