chore(profiling): remove redundant test runs for Lock profiler#16350
chore(profiling): remove redundant test runs for Lock profiler#16350vlad-scherbich merged 2 commits intomainfrom
Conversation
c133b9d to
2ef7fc8
Compare
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate vlad/consolidate-threading-tests (c98fbc6) with baseline main (eb517e9) 📈 Performance Regressions (4 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 105.082µs (SLO: <130.000µs 📉 -19.2%) vs baseline: +4.0% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 102.681µs (SLO: <130.000µs 📉 -21.0%) vs baseline: +0.6% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.3% ✅ add_inplace_noaspectTime: ✅ 28.299µs (SLO: <40.000µs 📉 -29.3%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.3% ✅ add_noaspectTime: ✅ 48.898µs (SLO: <70.000µs 📉 -30.1%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 250.964µs (SLO: <400.000µs 📉 -37.3%) vs baseline: ~same Memory: ✅ 43.175MB (SLO: <46.000MB -6.1%) vs baseline: +5.4% ✅ bytearray_extend_aspectTime: ✅ 644.907µs (SLO: <800.000µs 📉 -19.4%) vs baseline: +1.4% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.5% ✅ bytearray_extend_noaspectTime: ✅ 269.566µs (SLO: <400.000µs 📉 -32.6%) vs baseline: +1.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 139.955µs (SLO: <300.000µs 📉 -53.3%) vs baseline: +2.3% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ bytes_aspectTime: ✅ 221.467µs (SLO: <300.000µs 📉 -26.2%) vs baseline: +1.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 134.697µs (SLO: <200.000µs 📉 -32.7%) vs baseline: -0.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 3.860ms (SLO: <5.000ms 📉 -22.8%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ bytesio_noaspectTime: ✅ 319.670µs (SLO: <420.000µs 📉 -23.9%) vs baseline: +1.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 88.580µs (SLO: <300.000µs 📉 -70.5%) vs baseline: +0.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 259.800µs (SLO: <300.000µs 📉 -13.4%) vs baseline: +3.9% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 88.576µs (SLO: <500.000µs 📉 -82.3%) vs baseline: +0.8% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ casefold_noaspectTime: ✅ 311.337µs (SLO: <500.000µs 📉 -37.7%) vs baseline: +0.5% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ decode_aspectTime: ✅ 86.826µs (SLO: <100.000µs 📉 -13.2%) vs baseline: +0.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 154.063µs (SLO: <210.000µs 📉 -26.6%) vs baseline: +1.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 84.860µs (SLO: <200.000µs 📉 -57.6%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 142.604µs (SLO: <200.000µs 📉 -28.7%) vs baseline: +3.6% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ format_aspectTime: ✅ 14.729ms (SLO: <19.200ms 📉 -23.3%) vs baseline: +0.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.5% ✅ format_map_aspectTime: ✅ 16.450ms (SLO: <21.500ms 📉 -23.5%) vs baseline: ~same Memory: ✅ 43.254MB (SLO: <46.000MB -6.0%) vs baseline: +5.5% ✅ format_map_noaspectTime: ✅ 377.518µs (SLO: <500.000µs 📉 -24.5%) vs baseline: +2.8% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 305.373µs (SLO: <500.000µs 📉 -38.9%) vs baseline: +1.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 126.007µs (SLO: <300.000µs 📉 -58.0%) vs baseline: +2.9% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.601µs (SLO: <300.000µs 📉 -86.5%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 211.685µs (SLO: <300.000µs 📉 -29.4%) vs baseline: -2.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 139.771µs (SLO: <300.000µs 📉 -53.4%) vs baseline: -3.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 608.027µs (SLO: <700.000µs 📉 -13.1%) vs baseline: 📈 +21.7% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 256.775µs (SLO: <300.000µs 📉 -14.4%) vs baseline: +2.1% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 297.203µs (SLO: <500.000µs 📉 -40.6%) vs baseline: +0.9% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.2% ✅ lower_noaspectTime: ✅ 236.728µs (SLO: <300.000µs 📉 -21.1%) vs baseline: +1.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 0.278ms (SLO: <3.000ms 📉 -90.7%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -1.6% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 14.369ms (SLO: <18.750ms 📉 -23.4%) vs baseline: -0.2% Memory: ✅ 43.313MB (SLO: <46.000MB -5.8%) vs baseline: +5.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.851ms (SLO: <19.350ms 📉 -23.3%) vs baseline: -0.2% Memory: ✅ 43.195MB (SLO: <46.000MB -6.1%) vs baseline: +5.0% ✅ modulo_aspect_for_bytesTime: ✅ 14.415ms (SLO: <18.900ms 📉 -23.7%) vs baseline: -0.3% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.673ms (SLO: <19.150ms 📉 -23.4%) vs baseline: -0.3% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.360ms (SLO: <3.000ms 📉 -88.0%) vs baseline: -0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 18.419ms (SLO: <24.000ms 📉 -23.3%) vs baseline: -0.2% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 279.313µs (SLO: <300.000µs -6.9%) vs baseline: -1.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 316.494µs (SLO: <420.000µs 📉 -24.6%) vs baseline: -1.1% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 46.701µs (SLO: <90.000µs 📉 -48.1%) vs baseline: -0.5% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ rstrip_aspectTime: ✅ 390.676µs (SLO: <500.000µs 📉 -21.9%) vs baseline: -1.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 185.772µs (SLO: <300.000µs 📉 -38.1%) vs baseline: +1.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 183.936µs (SLO: <300.000µs 📉 -38.7%) vs baseline: -2.2% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 54.080µs (SLO: <90.000µs 📉 -39.9%) vs baseline: +0.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 3.878ms (SLO: <5.000ms 📉 -22.4%) vs baseline: -0.4% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 387.720µs (SLO: <500.000µs 📉 -22.5%) vs baseline: 📈 +12.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 274.711µs (SLO: <350.000µs 📉 -21.5%) vs baseline: -0.9% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 178.754µs (SLO: <240.000µs 📉 -25.5%) vs baseline: -1.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ swapcase_aspectTime: ✅ 346.376µs (SLO: <500.000µs 📉 -30.7%) vs baseline: +4.4% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +5.2% ✅ swapcase_noaspectTime: ✅ 276.552µs (SLO: <400.000µs 📉 -30.9%) vs baseline: +0.8% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 326.028µs (SLO: <500.000µs 📉 -34.8%) vs baseline: +1.1% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 262.310µs (SLO: <400.000µs 📉 -34.4%) vs baseline: +3.0% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ translate_aspectTime: ✅ 502.867µs (SLO: <700.000µs 📉 -28.2%) vs baseline: +3.5% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 425.867µs (SLO: <500.000µs 📉 -14.8%) vs baseline: +1.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 294.038µs (SLO: <500.000µs 📉 -41.2%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ upper_noaspectTime: ✅ 236.360µs (SLO: <400.000µs 📉 -40.9%) vs baseline: +2.1% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.3% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 513.239µs (SLO: <700.000µs 📉 -26.7%) vs baseline: 📈 +20.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.4% ✅ ospathbasename_noaspectTime: ✅ 436.417µs (SLO: <700.000µs 📉 -37.7%) vs baseline: -0.2% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +6.0% ✅ ospathjoin_aspectTime: ✅ 622.088µs (SLO: <700.000µs 📉 -11.1%) vs baseline: -0.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.9% ✅ ospathjoin_noaspectTime: ✅ 623.809µs (SLO: <700.000µs 📉 -10.9%) vs baseline: -1.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.9% ✅ ospathnormcase_aspectTime: ✅ 350.593µs (SLO: <700.000µs 📉 -49.9%) vs baseline: -2.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.7% ✅ ospathnormcase_noaspectTime: ✅ 362.737µs (SLO: <700.000µs 📉 -48.2%) vs baseline: -1.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.9% ✅ ospathsplit_aspectTime: ✅ 492.733µs (SLO: <700.000µs 📉 -29.6%) vs baseline: ~same Memory: ✅ 42.782MB (SLO: <46.000MB -7.0%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 498.720µs (SLO: <700.000µs 📉 -28.8%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.6% ✅ ospathsplitdrive_aspectTime: ✅ 376.574µs (SLO: <700.000µs 📉 -46.2%) vs baseline: -0.7% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.9% ✅ ospathsplitdrive_noaspectTime: ✅ 73.287µs (SLO: <700.000µs 📉 -89.5%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.6% ✅ ospathsplitext_aspectTime: ✅ 465.229µs (SLO: <700.000µs 📉 -33.5%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +6.0% ✅ ospathsplitext_noaspectTime: ✅ 468.055µs (SLO: <700.000µs 📉 -33.1%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.6% 📈 iastaspectssplit - 12/12✅ rsplit_aspectTime: ✅ 168.105µs (SLO: <250.000µs 📉 -32.8%) vs baseline: 📈 +13.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.8% ✅ rsplit_noaspectTime: ✅ 168.675µs (SLO: <250.000µs 📉 -32.5%) vs baseline: +9.9% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +6.0% ✅ split_aspectTime: ✅ 152.643µs (SLO: <250.000µs 📉 -38.9%) vs baseline: +5.1% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +6.0% ✅ split_noaspectTime: ✅ 166.342µs (SLO: <250.000µs 📉 -33.5%) vs baseline: +9.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.7% ✅ splitlines_aspectTime: ✅ 153.731µs (SLO: <250.000µs 📉 -38.5%) vs baseline: +6.3% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.7% ✅ splitlines_noaspectTime: ✅ 162.719µs (SLO: <250.000µs 📉 -34.9%) vs baseline: +7.9% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.490µs (SLO: <20.000µs 📉 -82.6%) vs baseline: 📈 +21.9% Memory: ✅ 35.763MB (SLO: <38.000MB -5.9%) vs baseline: +5.6% ✅ 1-count-metrics-100-timesTime: ✅ 204.709µs (SLO: <220.000µs -7.0%) vs baseline: +3.2% Memory: ✅ 35.665MB (SLO: <38.000MB -6.1%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.353µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +5.3% Memory: ✅ 35.645MB (SLO: <38.000MB -6.2%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.354µs (SLO: <230.000µs -5.1%) vs baseline: +3.0% Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.188µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +2.0% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.678µs (SLO: <150.000µs -8.9%) vs baseline: -0.2% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +5.3% ✅ 1-rate-metric-1-timesTime: ✅ 3.167µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +4.7% Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 220.447µs (SLO: <250.000µs 📉 -11.8%) vs baseline: +3.9% Memory: ✅ 35.684MB (SLO: <38.000MB -6.1%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.532ms (SLO: <22.000ms -6.7%) vs baseline: +2.8% Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.316ms (SLO: <2.550ms -9.2%) vs baseline: +4.0% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.395ms (SLO: <1.550ms 📉 -10.0%) vs baseline: -0.8% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.243ms (SLO: <2.550ms 📉 -12.1%) vs baseline: +2.5% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.540µs (SLO: <20.000µs 📉 -77.3%) vs baseline: +2.6% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 172.662µs (SLO: <250.000µs 📉 -30.9%) vs baseline: ~same Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.188ms (SLO: <2.500ms 📉 -12.5%) vs baseline: +0.5% Memory: ✅ 36.353MB (SLO: <38.750MB -6.2%) vs baseline: +4.9% 🟡 Near SLO Breach (1 suite)🟡 otelsdkspan - 24/24✅ add-eventTime: ✅ 40.736ms (SLO: <42.000ms -3.0%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <40.750MB -6.4%) vs baseline: +5.0% ✅ add-linkTime: ✅ 36.432ms (SLO: <38.550ms -5.5%) vs baseline: +1.0% Memory: ✅ 38.083MB (SLO: <40.750MB -6.5%) vs baseline: +5.2% ✅ add-metricsTime: ✅ 219.825ms (SLO: <232.000ms -5.2%) vs baseline: +0.4% Memory: ✅ 38.063MB (SLO: <40.750MB -6.6%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 213.220ms (SLO: <221.600ms -3.8%) vs baseline: +1.1% Memory: ✅ 38.024MB (SLO: <40.750MB -6.7%) vs baseline: +5.0% ✅ get-contextTime: ✅ 29.550ms (SLO: <31.300ms -5.6%) vs baseline: +1.6% Memory: ✅ 37.985MB (SLO: <40.750MB -6.8%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 29.483ms (SLO: <31.000ms -4.9%) vs baseline: +0.8% Memory: ✅ 38.103MB (SLO: <40.750MB -6.5%) vs baseline: +5.1% ✅ record-exceptionTime: ✅ 63.637ms (SLO: <65.850ms -3.4%) vs baseline: -0.1% Memory: ✅ 38.083MB (SLO: <40.750MB -6.5%) vs baseline: +5.2% ✅ set-statusTime: ✅ 32.200ms (SLO: <34.150ms -5.7%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <40.750MB -6.4%) vs baseline: +5.2% ✅ startTime: ✅ 29.694ms (SLO: <30.150ms 🟡 -1.5%) vs baseline: +3.0% Memory: ✅ 38.044MB (SLO: <40.750MB -6.6%) vs baseline: +4.9% ✅ start-finishTime: ✅ 33.981ms (SLO: <35.350ms -3.9%) vs baseline: ~same Memory: ✅ 38.122MB (SLO: <40.750MB -6.4%) vs baseline: +5.4% ✅ start-finish-telemetryTime: ✅ 33.979ms (SLO: <35.450ms -4.2%) vs baseline: +0.3% Memory: ✅ 38.142MB (SLO: <40.750MB -6.4%) vs baseline: +5.2% ✅ update-nameTime: ✅ 31.304ms (SLO: <33.400ms -6.3%) vs baseline: +1.2% Memory: ✅ 38.024MB (SLO: <40.750MB -6.7%) vs baseline: +4.7%
|
https://datadoghq.atlassian.net/browse/PROF-12725
Summary
Refactor
test_threading.pyto eliminate redundant test execution by separating generic profiling infrastructure tests from lock-type-specific tests. Previously, 22 generic tests ran 5 times (once per lock type), totaling 110 test runs. Now they run once usingthreading.Lock, reducing test execution by ~73%.Changes
Rationale
The 22 tests in
TestGenericLockProfilingverify the core profiling infrastructure:_ProfiledLockwrapper behavior (pickle, hash, equality, slots)This infrastructure is shared across all lock types - the same
_ProfiledLockclass wraps Lock, RLock, Semaphore, BoundedSemaphore, and Condition. Running these tests once withthreading.Lockis sufficient.Lock-type-specific tests remain in dedicated classes to verify:
_is_owned()for RLock)Test Count Comparison
Performance Impact