chore(tracer): add span info to _start_span_after_shutdown warning#16336
chore(tracer): add span info to _start_span_after_shutdown warning#16336
Conversation
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate munir/import-shutdown-warning (c714f85) with baseline main (5810ea0) 📈 Performance Regressions (4 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 106.634µs (SLO: <130.000µs 📉 -18.0%) vs baseline: +5.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 101.892µs (SLO: <130.000µs 📉 -21.6%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 28.162µs (SLO: <40.000µs 📉 -29.6%) vs baseline: +0.2% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 48.748µs (SLO: <70.000µs 📉 -30.4%) vs baseline: -0.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 252.482µs (SLO: <400.000µs 📉 -36.9%) vs baseline: +0.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 648.596µs (SLO: <800.000µs 📉 -18.9%) vs baseline: +1.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 270.788µs (SLO: <400.000µs 📉 -32.3%) vs baseline: +1.0% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 140.479µs (SLO: <300.000µs 📉 -53.2%) vs baseline: +1.9% Memory: ✅ 43.273MB (SLO: <46.000MB -5.9%) vs baseline: +5.5% ✅ bytes_aspectTime: ✅ 221.317µs (SLO: <300.000µs 📉 -26.2%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 134.873µs (SLO: <200.000µs 📉 -32.6%) vs baseline: -0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 3.873ms (SLO: <5.000ms 📉 -22.5%) vs baseline: +0.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 323.386µs (SLO: <420.000µs 📉 -23.0%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 88.661µs (SLO: <300.000µs 📉 -70.4%) vs baseline: +0.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 260.205µs (SLO: <300.000µs 📉 -13.3%) vs baseline: +2.4% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 89.070µs (SLO: <500.000µs 📉 -82.2%) vs baseline: +0.8% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.3% ✅ casefold_noaspectTime: ✅ 312.112µs (SLO: <500.000µs 📉 -37.6%) vs baseline: +1.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 86.765µs (SLO: <100.000µs 📉 -13.2%) vs baseline: -0.6% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 155.309µs (SLO: <210.000µs 📉 -26.0%) vs baseline: +2.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 85.010µs (SLO: <200.000µs 📉 -57.5%) vs baseline: -0.2% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 143.214µs (SLO: <200.000µs 📉 -28.4%) vs baseline: +2.5% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 14.675ms (SLO: <19.200ms 📉 -23.6%) vs baseline: ~same Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 16.449ms (SLO: <21.500ms 📉 -23.5%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 375.608µs (SLO: <500.000µs 📉 -24.9%) vs baseline: +1.9% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 307.049µs (SLO: <500.000µs 📉 -38.6%) vs baseline: +1.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 125.514µs (SLO: <300.000µs 📉 -58.2%) vs baseline: +1.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.513µs (SLO: <300.000µs 📉 -86.5%) vs baseline: +1.0% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 211.203µs (SLO: <300.000µs 📉 -29.6%) vs baseline: -2.8% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.4% ✅ join_noaspectTime: ✅ 141.551µs (SLO: <300.000µs 📉 -52.8%) vs baseline: -2.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 604.114µs (SLO: <700.000µs 📉 -13.7%) vs baseline: 📈 +20.9% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 258.764µs (SLO: <300.000µs 📉 -13.7%) vs baseline: +1.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 295.802µs (SLO: <500.000µs 📉 -40.8%) vs baseline: -0.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 235.761µs (SLO: <300.000µs 📉 -21.4%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 0.279ms (SLO: <3.000ms 📉 -90.7%) vs baseline: -0.3% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.180ms (SLO: <3.000ms 📉 -94.0%) vs baseline: -1.1% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 14.372ms (SLO: <18.750ms 📉 -23.4%) vs baseline: +0.2% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.837ms (SLO: <19.350ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 14.576ms (SLO: <18.900ms 📉 -22.9%) vs baseline: +0.8% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.641ms (SLO: <19.150ms 📉 -23.5%) vs baseline: -0.2% Memory: ✅ 43.313MB (SLO: <46.000MB -5.8%) vs baseline: +5.5% ✅ modulo_noaspectTime: ✅ 0.360ms (SLO: <3.000ms 📉 -88.0%) vs baseline: +1.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ replace_aspectTime: ✅ 18.408ms (SLO: <24.000ms 📉 -23.3%) vs baseline: -0.3% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 281.801µs (SLO: <300.000µs -6.1%) vs baseline: -0.8% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 316.576µs (SLO: <420.000µs 📉 -24.6%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 47.123µs (SLO: <90.000µs 📉 -47.6%) vs baseline: +0.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 391.926µs (SLO: <500.000µs 📉 -21.6%) vs baseline: -0.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 186.689µs (SLO: <300.000µs 📉 -37.8%) vs baseline: +2.6% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 185.096µs (SLO: <300.000µs 📉 -38.3%) vs baseline: -0.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 54.332µs (SLO: <90.000µs 📉 -39.6%) vs baseline: +1.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 3.912ms (SLO: <5.000ms 📉 -21.8%) vs baseline: +0.3% Memory: ✅ 43.214MB (SLO: <46.000MB -6.1%) vs baseline: +5.5% ✅ stringio_noaspectTime: ✅ 390.072µs (SLO: <500.000µs 📉 -22.0%) vs baseline: 📈 +11.8% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 277.004µs (SLO: <350.000µs 📉 -20.9%) vs baseline: -0.8% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 181.222µs (SLO: <240.000µs 📉 -24.5%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 342.308µs (SLO: <500.000µs 📉 -31.5%) vs baseline: +2.4% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ swapcase_noaspectTime: ✅ 278.790µs (SLO: <400.000µs 📉 -30.3%) vs baseline: +0.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 325.454µs (SLO: <500.000µs 📉 -34.9%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 264.904µs (SLO: <400.000µs 📉 -33.8%) vs baseline: +2.7% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 502.400µs (SLO: <700.000µs 📉 -28.2%) vs baseline: +3.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 426.005µs (SLO: <500.000µs 📉 -14.8%) vs baseline: +1.7% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 296.952µs (SLO: <500.000µs 📉 -40.6%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 237.422µs (SLO: <400.000µs 📉 -40.6%) vs baseline: +0.8% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.2% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 510.912µs (SLO: <700.000µs 📉 -27.0%) vs baseline: 📈 +18.1% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +6.4% ✅ ospathbasename_noaspectTime: ✅ 427.840µs (SLO: <700.000µs 📉 -38.9%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.7% ✅ ospathjoin_aspectTime: ✅ 616.699µs (SLO: <700.000µs 📉 -11.9%) vs baseline: -0.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +6.1% ✅ ospathjoin_noaspectTime: ✅ 619.667µs (SLO: <700.000µs 📉 -11.5%) vs baseline: -1.8% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.9% ✅ ospathnormcase_aspectTime: ✅ 351.515µs (SLO: <700.000µs 📉 -49.8%) vs baseline: -1.9% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.4% ✅ ospathnormcase_noaspectTime: ✅ 358.361µs (SLO: <700.000µs 📉 -48.8%) vs baseline: -1.1% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +6.2% ✅ ospathsplit_aspectTime: ✅ 490.288µs (SLO: <700.000µs 📉 -30.0%) vs baseline: -0.3% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +6.1% ✅ ospathsplit_noaspectTime: ✅ 500.876µs (SLO: <700.000µs 📉 -28.4%) vs baseline: +0.6% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +5.5% ✅ ospathsplitdrive_aspectTime: ✅ 372.053µs (SLO: <700.000µs 📉 -46.8%) vs baseline: -2.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.5% ✅ ospathsplitdrive_noaspectTime: ✅ 72.793µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 461.806µs (SLO: <700.000µs 📉 -34.0%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.9% ✅ ospathsplitext_noaspectTime: ✅ 461.134µs (SLO: <700.000µs 📉 -34.1%) vs baseline: -1.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.7% 📈 iastaspectssplit - 12/12✅ rsplit_aspectTime: ✅ 169.367µs (SLO: <250.000µs 📉 -32.3%) vs baseline: 📈 +14.6% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +6.2% ✅ rsplit_noaspectTime: ✅ 173.986µs (SLO: <250.000µs 📉 -30.4%) vs baseline: 📈 +11.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.7% ✅ split_aspectTime: ✅ 153.981µs (SLO: <250.000µs 📉 -38.4%) vs baseline: +5.3% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.8% ✅ split_noaspectTime: ✅ 167.429µs (SLO: <250.000µs 📉 -33.0%) vs baseline: 📈 +10.7% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.6% ✅ splitlines_aspectTime: ✅ 152.600µs (SLO: <250.000µs 📉 -39.0%) vs baseline: +3.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.6% ✅ splitlines_noaspectTime: ✅ 161.658µs (SLO: <250.000µs 📉 -35.3%) vs baseline: +7.2% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.522µs (SLO: <20.000µs 📉 -82.4%) vs baseline: 📈 +19.8% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +6.0% ✅ 1-count-metrics-100-timesTime: ✅ 207.913µs (SLO: <220.000µs -5.5%) vs baseline: +3.0% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +6.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.400µs (SLO: <20.000µs 📉 -83.0%) vs baseline: +4.4% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 220.935µs (SLO: <230.000µs -3.9%) vs baseline: +2.4% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +6.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.190µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +2.1% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +5.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.448µs (SLO: <150.000µs -9.7%) vs baseline: -1.4% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.200µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +5.2% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +5.9% ✅ 1-rate-metrics-100-timesTime: ✅ 221.449µs (SLO: <250.000µs 📉 -11.4%) vs baseline: +2.4% Memory: ✅ 35.429MB (SLO: <38.000MB -6.8%) vs baseline: +5.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.443ms (SLO: <22.000ms -7.1%) vs baseline: +2.3% Memory: ✅ 35.507MB (SLO: <38.000MB -6.6%) vs baseline: +5.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.273ms (SLO: <2.550ms 📉 -10.9%) vs baseline: +3.5% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.399ms (SLO: <1.550ms -9.8%) vs baseline: -0.8% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +6.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.223ms (SLO: <2.550ms 📉 -12.8%) vs baseline: +2.7% Memory: ✅ 35.507MB (SLO: <38.000MB -6.6%) vs baseline: +5.9% ✅ flush-1-metricTime: ✅ 4.599µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +2.1% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.937µs (SLO: <250.000µs 📉 -30.4%) vs baseline: +0.5% Memory: ✅ 35.724MB (SLO: <38.000MB -6.0%) vs baseline: +5.4% ✅ flush-1000-metricsTime: ✅ 2.178ms (SLO: <2.500ms 📉 -12.9%) vs baseline: -0.3% Memory: ✅ 36.392MB (SLO: <38.750MB -6.1%) vs baseline: +4.7%
|
Codeowners resolved as |
Description
Testing
Updated tracer shutdown test cases to ensure warning is logged for both tracer.start_span and tracer.trace
Risks
None