-
Notifications
You must be signed in to change notification settings - Fork 324
Remove remaining use of JAVA_X_HOME
#10340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bric3
wants to merge
7
commits into
master
Choose a base branch
from
bdu/remove-remaining-use-of-JAVA_X_HOME
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+216
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087609
Total [baseline] (8.779 s) : 0, 8778986
Agent [candidate] (1.085 s) : 0, 1085147
Total [candidate] (8.745 s) : 0, 8745259
section iast
Agent [baseline] (1.225 s) : 0, 1225106
Total [baseline] (9.318 s) : 0, 9317987
Agent [candidate] (1.235 s) : 0, 1234688
Total [candidate] (9.372 s) : 0, 9371936
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (653.79 ms) : 0, 653790
BytebuddyAgent [candidate] (651.943 ms) : 0, 651943
GlobalTracer [baseline] (283.543 ms) : 0, 283543
GlobalTracer [candidate] (283.215 ms) : 0, 283215
AppSec [baseline] (32.672 ms) : 0, 32672
AppSec [candidate] (32.634 ms) : 0, 32634
Debugger [baseline] (67.14 ms) : 0, 67140
Debugger [candidate] (67.217 ms) : 0, 67217
Remote Config [baseline] (642.351 µs) : 0, 642
Remote Config [candidate] (632.923 µs) : 0, 633
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (8.924 ms) : 0, 8924
Flare Poller [baseline] (3.889 ms) : 0, 3889
Flare Poller [candidate] (3.746 ms) : 0, 3746
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (792.244 ms) : 0, 792244
BytebuddyAgent [candidate] (798.973 ms) : 0, 798973
GlobalTracer [baseline] (257.129 ms) : 0, 257129
GlobalTracer [candidate] (259.036 ms) : 0, 259036
IAST [baseline] (27.056 ms) : 0, 27056
IAST [candidate] (27.251 ms) : 0, 27251
AppSec [baseline] (35.247 ms) : 0, 35247
AppSec [candidate] (35.246 ms) : 0, 35246
Debugger [baseline] (64.096 ms) : 0, 64096
Debugger [candidate] (64.541 ms) : 0, 64541
Remote Config [baseline] (584.209 µs) : 0, 584
Remote Config [candidate] (586.505 µs) : 0, 587
Telemetry [baseline] (8.459 ms) : 0, 8459
Telemetry [candidate] (8.513 ms) : 0, 8513
Flare Poller [baseline] (3.583 ms) : 0, 3583
Flare Poller [candidate] (3.643 ms) : 0, 3643
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086259
Total [baseline] (10.789 s) : 0, 10788658
Agent [candidate] (1.095 s) : 0, 1095247
Total [candidate] (10.845 s) : 0, 10844949
section appsec
Agent [baseline] (1.277 s) : 0, 1277242
Total [baseline] (11.102 s) : 0, 11101514
Agent [candidate] (1.268 s) : 0, 1267805
Total [candidate] (11.038 s) : 0, 11037953
section iast
Agent [baseline] (1.225 s) : 0, 1225471
Total [baseline] (11.184 s) : 0, 11184236
Agent [candidate] (1.228 s) : 0, 1228379
Total [candidate] (11.212 s) : 0, 11211600
section profiling
Agent [baseline] (1.205 s) : 0, 1205205
Total [baseline] (10.884 s) : 0, 10883511
Agent [candidate] (1.223 s) : 0, 1223025
Total [candidate] (11.122 s) : 0, 11122342
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (652.112 ms) : 0, 652112
BytebuddyAgent [candidate] (656.933 ms) : 0, 656933
GlobalTracer [baseline] (283.051 ms) : 0, 283051
GlobalTracer [candidate] (285.215 ms) : 0, 285215
AppSec [baseline] (32.597 ms) : 0, 32597
AppSec [candidate] (33.017 ms) : 0, 33017
Debugger [baseline] (68.378 ms) : 0, 68378
Debugger [candidate] (69.677 ms) : 0, 69677
Remote Config [baseline] (641.481 µs) : 0, 641
Remote Config [candidate] (668.148 µs) : 0, 668
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (8.983 ms) : 0, 8983
Flare Poller [baseline] (3.825 ms) : 0, 3825
Flare Poller [candidate] (3.806 ms) : 0, 3806
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (697.295 ms) : 0, 697295
BytebuddyAgent [candidate] (692.865 ms) : 0, 692865
GlobalTracer [baseline] (261.21 ms) : 0, 261210
GlobalTracer [candidate] (259.04 ms) : 0, 259040
IAST [baseline] (25.226 ms) : 0, 25226
IAST [candidate] (24.523 ms) : 0, 24523
AppSec [baseline] (175.644 ms) : 0, 175644
AppSec [candidate] (173.644 ms) : 0, 173644
Debugger [baseline] (67.211 ms) : 0, 67211
Debugger [candidate] (67.113 ms) : 0, 67113
Remote Config [baseline] (763.702 µs) : 0, 764
Remote Config [candidate] (780.145 µs) : 0, 780
Telemetry [baseline] (9.364 ms) : 0, 9364
Telemetry [candidate] (9.426 ms) : 0, 9426
Flare Poller [baseline] (3.704 ms) : 0, 3704
Flare Poller [candidate] (3.709 ms) : 0, 3709
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (792.276 ms) : 0, 792276
BytebuddyAgent [candidate] (793.721 ms) : 0, 793721
GlobalTracer [baseline] (256.686 ms) : 0, 256686
GlobalTracer [candidate] (257.894 ms) : 0, 257894
IAST [baseline] (26.916 ms) : 0, 26916
IAST [candidate] (27.08 ms) : 0, 27080
AppSec [baseline] (32.391 ms) : 0, 32391
AppSec [candidate] (34.409 ms) : 0, 34409
Debugger [baseline] (67.747 ms) : 0, 67747
Debugger [candidate] (65.847 ms) : 0, 65847
Remote Config [baseline] (602.847 µs) : 0, 603
Remote Config [candidate] (611.404 µs) : 0, 611
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.576 ms) : 0, 8576
Flare Poller [baseline] (3.577 ms) : 0, 3577
Flare Poller [candidate] (3.559 ms) : 0, 3559
section profiling
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (702.508 ms) : 0, 702508
BytebuddyAgent [candidate] (712.759 ms) : 0, 712759
GlobalTracer [baseline] (221.07 ms) : 0, 221070
GlobalTracer [candidate] (223.659 ms) : 0, 223659
AppSec [baseline] (32.162 ms) : 0, 32162
AppSec [candidate] (32.711 ms) : 0, 32711
Debugger [baseline] (67.911 ms) : 0, 67911
Debugger [candidate] (69.441 ms) : 0, 69441
Remote Config [baseline] (650.711 µs) : 0, 651
Remote Config [candidate] (672.474 µs) : 0, 672
Telemetry [baseline] (8.861 ms) : 0, 8861
Telemetry [candidate] (9.142 ms) : 0, 9142
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.87 ms) : 0, 3870
ProfilingAgent [baseline] (97.098 ms) : 0, 97098
ProfilingAgent [candidate] (98.854 ms) : 0, 98854
Profiling [baseline] (97.682 ms) : 0, 97682
Profiling [candidate] (99.449 ms) : 0, 99449
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (1.299 ms) : 1286, 1312
. : milestone, 1299,
iast (3.311 ms) : 3269, 3352
. : milestone, 3311,
iast_FULL (6.388 ms) : 6320, 6455
. : milestone, 6388,
iast_GLOBAL (3.783 ms) : 3718, 3847
. : milestone, 3783,
profiling (2.261 ms) : 2238, 2283
. : milestone, 2261,
tracing (2.029 ms) : 2011, 2047
. : milestone, 2029,
section candidate
no_agent (1.285 ms) : 1273, 1296
. : milestone, 1285,
iast (3.532 ms) : 3476, 3588
. : milestone, 3532,
iast_FULL (6.318 ms) : 6253, 6383
. : milestone, 6318,
iast_GLOBAL (3.847 ms) : 3780, 3914
. : milestone, 3847,
profiling (2.159 ms) : 2140, 2178
. : milestone, 2159,
tracing (1.97 ms) : 1953, 1987
. : milestone, 1970,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (19.64 ms) : 19434, 19846
. : milestone, 19640,
appsec (19.277 ms) : 19082, 19473
. : milestone, 19277,
code_origins (18.2 ms) : 18018, 18383
. : milestone, 18200,
iast (19.173 ms) : 18977, 19369
. : milestone, 19173,
profiling (20.957 ms) : 20734, 21179
. : milestone, 20957,
tracing (18.251 ms) : 18068, 18434
. : milestone, 18251,
section candidate
no_agent (18.812 ms) : 18618, 19005
. : milestone, 18812,
appsec (20.01 ms) : 19804, 20216
. : milestone, 20010,
code_origins (18.195 ms) : 18010, 18379
. : milestone, 18195,
iast (18.351 ms) : 18161, 18541
. : milestone, 18351,
profiling (19.159 ms) : 18968, 19351
. : milestone, 19159,
tracing (17.981 ms) : 17799, 18163
. : milestone, 17981,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (15.244 s) : 15244000, 15244000
. : milestone, 15244000,
appsec (13.964 s) : 13964000, 13964000
. : milestone, 13964000,
iast (17.644 s) : 17644000, 17644000
. : milestone, 17644000,
iast_GLOBAL (17.093 s) : 17093000, 17093000
. : milestone, 17093000,
profiling (14.513 s) : 14513000, 14513000
. : milestone, 14513000,
tracing (14.14 s) : 14140000, 14140000
. : milestone, 14140000,
section candidate
no_agent (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
appsec (14.137 s) : 14137000, 14137000
. : milestone, 14137000,
iast (17.843 s) : 17843000, 17843000
. : milestone, 17843000,
iast_GLOBAL (17.231 s) : 17231000, 17231000
. : milestone, 17231000,
profiling (14.734 s) : 14734000, 14734000
. : milestone, 14734000,
tracing (14.193 s) : 14193000, 14193000
. : milestone, 14193000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~bea5f86e62, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1498
. : milestone, 1487,
appsec (4.176 ms) : 3922, 4431
. : milestone, 4176,
iast (2.572 ms) : 2470, 2674
. : milestone, 2572,
iast_GLOBAL (2.632 ms) : 2530, 2735
. : milestone, 2632,
profiling (2.405 ms) : 2319, 2492
. : milestone, 2405,
tracing (2.373 ms) : 2289, 2457
. : milestone, 2373,
section candidate
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (2.804 ms) : 2719, 2889
. : milestone, 2804,
iast (2.577 ms) : 2475, 2679
. : milestone, 2577,
iast_GLOBAL (2.623 ms) : 2521, 2726
. : milestone, 2623,
profiling (2.411 ms) : 2324, 2498
. : milestone, 2411,
tracing (2.357 ms) : 2274, 2441
. : milestone, 2357,
|
a1e732b to
e6e93dd
Compare
…A_*_HOME env vars
ad686ad to
bea5f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR allows to completely get rid of setting up JAVA_X_HOME on local dev environment.
The
stablespecial word has special handling though, that is using Gradle internal toolchain registry, and fallback to env vars. However, this mainly affect CI.Motivation
Easier project setup
Additional Notes
After this PR, setting up JAVA_X_HOME won't be needed anymore. One can use
-PtestJvm=..., e.g.-PtestJvm=11,-PtestJvm=graalvm17, ...