Repository navigation
Report framework-confirmed empty test executions as skipped - #321
juan-fernandez wants to merge 4 commits into
Conversation
|
/datadog autotest review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
|
/datadog autotest review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
More details
Empty classification requires completed framework evidence—zero XCTest executions or normal Swift Testing scope completion without tests—while failures, incomplete suites, and mixed modules remain non-empty.
🤖 Bits Code Review · Commit b6a4b06 · @DataDog review to ask questions
There was a problem hiding this comment.
Share the skip/empty reason values as DDTagValues constants, read module state once at teardown, and deduplicate helpers in the new tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
It has more edge cases: crash will create empty suites after the restart for all already passed suites, Swift Testing can have suite hierarchy with wrapper suites with zero tests in them. It needs more complex solution. Created SDTEST-3983 to track the problem. |
What and why?
Successful executions with no selected tests can leave their module and session reported as passed. Report framework-confirmed empty executions as skipped, with an explanation, without treating missing SDK events alone as proof that no tests ran.
How?
test.skip_reasonto confirmed-empty modules and sessions, andtest.session.empty_reason:zero_teststo confirmed-empty sessions. Empty suite events remain suppressed.Validation: Swift syntax parsing and
git diff --checkpassed. Native SDK tests could not run locally because only Command Line Tools are installed; full Xcode is required. Runtime verification remains pending.Review checklist