Light splat helper refactors#691
Open
FalloutFalcon wants to merge 9 commits intoDarkPack13:masterfrom
Open
Conversation
Contributor
|
changelog |
Member
Author
Changelog (atleast in TG) arent required if its a non-player facing code change. As the changelog is primarly for the players... |
Contributor
There was a problem hiding this comment.
I'd argue that none of these should exist since their entire purpose is to ignore edge cases and introduce unpredictable behavior (eg, an abomination can have its primary splat be either Kindred or Garou based only on the mood the code was in)
Member
Author
There was a problem hiding this comment.
We can just make sure they have unique ids then. Let me fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds logic for getting the "most important" splat on a mob, functionally right now, its the firs full splat you have.
Renames the issplat helpers to be more clear that they are getters instead of returning truth
Why It's Good For The Game
In theory should simplfy some logic if you need to decide a singular splat to use. And some helpers for halfsplat checks if someone finds that useful
issplat is a bit confusing.
Changelog
🆑
refactor: Cleans up some syntax on splat helpers
/:cl: