Skip to content

Speed up popup initial render#1522

Open
KillariDev wants to merge 1 commit into
mainfrom
t3code/popup-faster-load
Open

Speed up popup initial render#1522
KillariDev wants to merge 1 commit into
mainfrom
t3code/popup-faster-load

Conversation

@KillariDev

Copy link
Copy Markdown
Contributor

Summary

  • Render the Home popup immediately from safe default state instead of blocking on the full settings/home-data refresh spinner.
  • Keep pre-load defaults display-only by disabling and no-oping mutation paths until the first real popup_UpdateHomePage arrives.
  • Guard hidden paste-address handling before initial home data so it cannot navigate or write using fallback state.
  • Use a static MV3 default_popup in the manifest and remove runtime popup setup from the service worker startup path.
  • Add lightweight popup home-data request flags so initial popup open can skip signer refreshes and website-access metadata unless those are actually needed.
  • Preserve signer/access-triggered refresh behavior for updates that do need fresh signer accounts or website metadata.
  • Fix the stacked transaction benchmark by stripping the local mock transaction hash BigInt before preparing eth_simulateV1 RPC calls.
  • Add benchmark diagnostics for transaction dialog waits and confirm-popup failures.
  • Restore and cover wallet_revokePermissions behavior so popup optimization work does not regress account access revocation.

Validation

  • bun test
  • bun run setup-chrome
  • bun run typecheck
  • bun run lint
  • bun run benchmark:popup-lifecycle

Review

  • Project reviewer final pass: no High, Medium, or Low findings; score 94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant