Add README with documentation, links and acknowledgements - #8
Conversation
Based on the unmerged upstream draft on RP-Kit/RPKit's docs/create-readme branch, adapted for this fork and corrected where the draft disagreed with the tree: configuration is generated per-module rather than into a single plugins/RPKit folder, Bukkit module JARs land under bukkit/<module>/build/libs, and JDK 17 is now stated as a requirement. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Each database-backed module writes its own SQLite file named after the module, so naming rpkit_players.db alone read as a universal default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Self-review rubricScored against the diff at
Claim-by-claim verificationEach factual assertion was re-checked against the tree at this head:
Item fixed during this review
Outstanding limitationThe liveness of the three external upstream links (website, wiki, Discord) remains unchecked, as outbound HTTP is unavailable in the environment this change was prepared in. Those URLs are carried over verbatim from the upstream author's own draft and are labelled as upstream resources. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). |
Summary
README.mdis added, covering the description, quick links, table of contents, support, installation, compiling, contributing, acknowledgements and licence sections the mirrored issue asks for.RP-Kit/RPKit'sdocs/create-readmebranch (commitad6bc83e), so the wording reflects what the upstream author actually wrote rather than a fresh composition.plugins/rpk-players-bukkit/database.yml), not into a singleplugins/RPKit/config.yml— traced frombukkit/rpk-players-bukkit/src/main/kotlin/com/rpkit/players/bukkit/RPKPlayersBukkit.kt:81-116;bukkit/<module>/build/libs, not<module>/build/libs;.github/workflows/build.ymland the Gradle 7.6 / Kotlin 1.7.22 /jvmTarget 17pinning.build.gradlebump to2.5.0-SNAPSHOTis deliberately excluded as unrelated to documentation.Dans-Plugins/RPKit; the website, wiki and Discord remain pointed upstream and are labelled as upstream resources.Test plan
README.mdexists at the repository root with every section named in the mirrored issue's acceptance criteriagrep -c "^include" settings.gradlegradle/wrapper/gradle-wrapper.properties(gradle-7.6-bin.zip)jvmTargetcross-checked againstbuild.gradle.github/workflows/build.ymlMYSQL,SQLITE) and the SQLite default cross-checked againstRPKPlayersBukkit.ktandbukkit/rpk-players-bukkit/src/main/resources/database.ymlbukkit/rpk-players-bukkit/src/main/resources/plugin.yml-all.jarclaim cross-checked against the shadow plugin configuration inbukkit/rpk-core-bukkit/build.gradleand the absence of anyarchiveClassifieroverride across the treeAnchor verdict
Documentation-only: no Kotlin source, no build file, no
plugin.yml, and no workflow is modified, so neithercompileKotlinnortestcan observe this change. The CI run on this pull request's head is nonetheless expected to be green and is reported below once it completes.Closes #7
Upstream: RP-Kit#667
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).