Pin the endpoint webserver adapter explicitly - #1050
Open
DROOdotFOO wants to merge 4 commits into
Open
DROOdotFOO wants to merge 4 commits into
DROOdotFOO wants to merge 4 commits into
Conversation
`Raxol.Endpoint` set no `adapter:`, so it inherited Phoenix's default.
That default is Cowboy only for backwards compatibility --
`Phoenix.Endpoint.Supervisor` says so itself:
Even though Bandit is the default in apps generated via the
installer, we continue to use Cowboy as the default if not
explicitly specified for backwards compatibility.
TODO: Change this to default to Bandit in 2.0
`plug_cowboy` is this project's declared webserver and `bandit` appears
in no mix.lock anywhere in the repo, so a Phoenix 2.0 bump would have
silently repointed the endpoint at a dependency that is not present.
Naming the adapter makes the choice reviewable and turns that upgrade
into a deliberate edit instead of a boot failure.
No behaviour change today: this pins what was already resolving.
Found while establishing whether `plug_cowboy` could be dropped to
retire the cowlib advisories. It cannot -- Cowboy is live and serving --
but the silent inheritance is worth closing regardless.
Unified Regression Test ResultsWorkflow: Unified Regression Testing Performance ResultsFound 1 performance result(s) Memory ResultsFound 3 memory result(s) Targets
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the declared Cowboy endpoint adapter and hardens both the root development endpoint and the deployed playground listener.
Phoenix.Endpoint.Cowboy2Adapterin both endpoint configs.Manual testing
127.0.0.2,::1,0.0.0.0, and192.0.2.10git diff --check