Likely Minor: cleanup the mutex attributes object after mutex pthread_mutex_init().… #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pthread_mutex_init() temporarily uses the attributes object for configuration but does not take ownership.
ab9rf
approved these changes
Dec 6, 2024
Member
There was a problem hiding this comment.
i did verify that, per the spec:
After a mutex attributes object has been used to initialize one or more mutexes, any function affecting the attributes object (including destruction) shall not affect any previously initialized mutexes.
so this is safe
myk002
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pthread_mutex_init() temporarily uses the attributes object for configuration but does not take any ownership.
There is a memory allocation performed by pthread_mutexattr_init().
Assuming luai_userstateopen() is only called once or rarely, this resolves a small resource leak.