Skip to content

Redesign Currency screen and fix broken rate sources #130

Open
chaitika wants to merge 13 commits into
CypherCommons:masterfrom
chaitika:fix-currency
Open

Redesign Currency screen and fix broken rate sources #130
chaitika wants to merge 13 commits into
CypherCommons:masterfrom
chaitika:fix-currency

Conversation

@chaitika

Copy link
Copy Markdown
Contributor

image image

Copilot AI review requested due to automatic review settings July 16, 2026 15:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 16, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 16, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@notTanveer

notTanveer commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

search bar not accurate / not working..
image

@notTanveer

Copy link
Copy Markdown
Contributor
  • the font weight should be regular for the icons.
  • a lil more space between "USD" and "US Dollar".
  • the top currencies, USD, EUR, GBP, CAD, INR, etc, should be available at the top, and the rest could follow later alphabetically
Expected Current
Expected Current

@chaitika

Copy link
Copy Markdown
Contributor Author

search bar not accurate / not working..

INR is selected already, so doesnot show up in search. can you try with some other currency like usd, etc.

@notTanveer

notTanveer commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

INR is selected already, so doesnot show up in search. can you try with some other currency like usd, etc.

not working

WhatsApp.Video.2026-07-19.at.4.57.16.PM.mp4

chaitika added 6 commits July 23, 2026 16:07
The Currency.tsx redesign dropped the last references to loc._.never
that find-unused-loc.js could see, since the script never scans loc/
itself where transactionTimeToReadable() still uses that key. Add
loc/ to the scanned dirs to close that gap, and fix two real lint
errors the unused-loc gate had been masking: a missing colors.successCheck
dependency in Currency's renderItem callback, and an inline-style
ternary in SettingsIconWrapper.
Copilot AI review requested due to automatic review settings July 24, 2026 14:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants