REF: convert fee-bump screens (CPFP, RBF) to TypeScript functional components#126
Open
NAME-ASHWANIYADAV wants to merge 1 commit into
Open
Conversation
Author
|
@theanmolsharma @chaitika PTAL !! |
Contributor
|
afaiu, the wallet doesn't plan on supporting rbf and cpfp in near future, these files are inherited code from bluewallet.. |
NAME-ASHWANIYADAV
force-pushed
the
ref/convert-fee-bump-screens-to-tsx
branch
from
July 10, 2026 20:19
4d6c7d1 to
5042e9a
Compare
Author
|
@chaitika Thanks for the feedback! Updated the PR to delete these inherited BlueWallet files and clean up all navigation/state/locale references. hd-segwit-bech32-transaction.ts cleanup will be a follow-up PR |
NAME-ASHWANIYADAV
force-pushed
the
ref/convert-fee-bump-screens-to-tsx
branch
from
July 19, 2026 22:05
5042e9a to
e5553ac
Compare
Author
|
@notTanveer @chaitika @theanmolsharma have a look !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
What
Convert the three fee-bump transaction screens from JavaScript Class Components
to TypeScript Functional Components:
screen/transactions/CPFP.js->CPFP.tsxscreen/transactions/RBFBumpFee.js->RBFBumpFee.tsxscreen/transactions/RBFCancel.js->RBFCancel.tsxWhy
PropTypes,this.state,and
componentDidMount- now modernized to hooksPropTypesin favor of TypeScript static typesBlueCurrentThemewithuseTheme()hookcontextType = StorageContextwithuseStorage()hookisElectrumDisabledaccess withuseSettings()hook(consistent with other screens like
Confirm.tsx,WalletsList.tsx)How
class extends Component-> functional components with hooksthis.state->useState()componentDidMount->useEffect()PropTypes-> TypeScript types (viaDetailViewStackParamList)BlueCurrentTheme.colors->useTheme().colorsRBFBumpFee extends CPFP) -> standalone componentsTesting
npx tsc --noEmit- zero errors in these files