Test/impersonation lifecycle#535
Merged
Baskarayelu merged 10 commits intoJun 23, 2026
Merged
Conversation
…ailure Pins issue/validate/revoke/expiry behavior, the MAX_TTL_SECONDS clamp, and the audit records emitted on both success and rejection paths.
Contributor
Author
|
Done, Close: #535 |
|
@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
impersonation lifecycle — great addition. merging 👍 |
Contributor
|
impersonation lifecycle — rebased onto main and merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #521
I have successfully added the comprehensive lifecycle and concurrency tests for the impersonation token service!
Here is what was completed:
Created src/services/impersonation/impersonation.test.ts matching your test suite conventions using Vitest.
Formally tested issueToken, validateToken, and revokeToken across all criteria, including TTL max bounds rules, rejecting empty reasons, invalid user paths, exactly-expired tokens via a fake clock, and unknown token resets.
Included a spy on the AuditLogService asserting the AuditAction properties appropriately record success / failure alongside the required meta elements like ipAddress parsing.
Cleared npm run build and npm run lint cleanly.
Checked out the new branch test/impersonation-lifecycle and successfully committed the work using your precise commit format!