Skip to content

Clearer descriptions for parameters to Slack, Confluence, Microsoft, Notion, Github, Gitlab actions#456

Open
rb0000 wants to merge 6 commits intomainfrom
rb/audit-action-names
Open

Clearer descriptions for parameters to Slack, Confluence, Microsoft, Notion, Github, Gitlab actions#456
rb0000 wants to merge 6 commits intomainfrom
rb/audit-action-names

Conversation

@rb0000
Copy link
Copy Markdown
Contributor

@rb0000 rb0000 commented Jan 8, 2026

No description provided.

Comment thread src/actions/autogen/types.ts
Comment thread src/actions/schema.yaml
type: string
description: The team ID of the Microsoft Teams channel
description: The team ID of the Microsoft Teams channel to send a message to
tags: [recommend-predefined]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tags need quotes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait jk, they shouldn't have quotes. some of them do tho if you want to take them off the ones your tagged

Comment thread src/actions/schema.yaml Outdated
description: The organization that owns the repository
description: The organization that owns the GitHub repository
tags: [recommend-predefined]
repository:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be repositoryName

Copy link
Copy Markdown
Contributor

@liv-s liv-s Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's a few instances of this in the code

rb0000 and others added 3 commits January 8, 2026 15:57
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

export const microsoftUpdateDocumentParamsSchema = z.object({
siteId: z.string().describe("The ID of the site where the document is located").optional(),
siteId: z.string().describe("The ID of the Sharepoint site where the document is located").optional(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Sharepoint should be capitalized as SharePoint to match the official spelling.

Suggested change
siteId: z.string().describe("The ID of the Sharepoint site where the document is located").optional(),
siteId: z.string().describe("The ID of the SharePoint site where the document is located").optional(),

Comment thread src/actions/autogen/templates.ts Outdated
type: "string",
description: "Project gid the task belongs to",
tags: ["recommend-predefined"],
tags: [recommend-predefined],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: It seems like the string literal for the tag is missing quotes. Replace tags: [recommend-predefined] with tags: ["recommend-predefined"] to ensure the tag is recognized as a string.

Comment thread src/actions/autogen/templates.ts Outdated
type: "string",
description: "The key for the project you want to add it to",
tags: ["recommend-predefined"],
tags: [recommend-predefined],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: The tag identifier recommend-predefined should be a string literal. Please wrap it in quotes as "recommend-predefined".

Comment thread src/actions/autogen/templates.ts Outdated
type: "string",
description: "The key for the project",
tags: ["recommend-predefined"],
tags: [recommend-predefined],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical issue: The tag value recommend-predefined is not in quotes. It should likely be a string literal (e.g., "recommend-predefined") to match its intended usage.

Comment thread src/actions/autogen/templates.ts Outdated
type: "string",
description: "The key for the project you want to add it to",
tags: ["recommend-predefined"],
tags: [recommend-predefined],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error: The tag value should be a string literal. It should be written as tags: ["recommend-predefined"].

Comment thread src/actions/autogen/templates.ts Outdated
type: "string",
description: "The key for the project",
tags: ["recommend-predefined"],
tags: [recommend-predefined],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: The tag value in the array should be a string literal. It appears as [recommend-predefined] (without quotes) instead of "recommend-predefined". Please wrap it in quotes for consistency.

Comment thread src/actions/autogen/templates.ts Outdated
type: "string",
description: 'The name of the GitLab project (e.g., "my-repo")',
tags: ["recommend-predefined"],
tags: [recommend-predefined],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error: The identifier recommend-predefined appears without quotes. If a string literal was intended, please add quotes.

Comment thread src/actions/schema.yaml
type: string
description: Project gid the task belongs to
tags: ["recommend-predefined"]
tags: [recommend-predefined]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical note: The tag value is now unquoted (tags: [recommend-predefined]), which could lead to parsing inconsistencies. For clarity and consistency with similar schema entries, consider quoting it (i.e. tags: ["recommend-predefined"]).

Comment thread src/actions/schema.yaml
type: string
description: The subdomain of the Zendesk account
tags: ["recommend-predefined"]
tags: [recommend-predefined]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo/lexicographical note: The tag value is now unquoted (from ["recommend-predefined"] to [recommend-predefined]). For clarity and to avoid potential YAML parsing issues, please consider wrapping 'recommend-predefined' in quotes.

Comment thread src/actions/schema.yaml
type: string
description: The subdomain of the Zendesk account
tags: ["recommend-predefined"]
tags: [recommend-predefined]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo/lexicographical note: The tag value changed from a quoted string ("recommend-predefined") to an unquoted one (recommend-predefined). If this value is intended as a string literal, it should be quoted to avoid potential YAML parsing issues.

Comment thread src/actions/schema.yaml
description: The ID of the calendar containing the event
tags: ["recommend-predefined"]
description: The ID of the calendar containing the event. This can be a person's email.
tags: [recommend-predefined]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array item on this line has been changed from a quoted string ("recommend-predefined") to an unquoted token (recommend-predefined). Although YAML may treat this as a string, it might be safer and clearer to quote it (especially given the hyphen) to avoid any potential parsing ambiguities. Please consider restoring the quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants