Bypass executable check when creating RunSettings#786
Open
ashao wants to merge 1 commit intoCrayLabs:developfrom
Open
Bypass executable check when creating RunSettings#786ashao wants to merge 1 commit intoCrayLabs:developfrom
ashao wants to merge 1 commit intoCrayLabs:developfrom
Conversation
In some instances, the strong check that the executable can be found by the driver script when creating RunSettings is too restrictive. This can occur in cases where the binary does not exist on the node where the driver script is being launched (e.g. remote execution) or for binaries which need to be found after setting environment variables.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #786 +/- ##
===========================================
- Coverage 83.91% 81.72% -2.19%
===========================================
Files 83 84 +1
Lines 6284 7011 +727
===========================================
+ Hits 5273 5730 +457
- Misses 1011 1281 +270
🚀 New features to boost your workflow:
|
al-rigazzi
requested changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some instances, the strong check that the executable can be found by the driver script when creating RunSettings is too restrictive. This can occur in cases where the binary does not exist on the node where the driver script is being launched (e.g. remote execution) or for binaries which need to be found after setting environment variables.