Repository navigation
ci: fix downstream sidebar E2E approval and evidence reporting - #13
Merged
Shimada666 merged 2 commits intoSep 23, 2026
Merged
Shimada666 merged 2 commits into
Shimada666 merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sidebar E2E scenarios wait for a background-running indicator while Smart approval is still waiting on the sentinel shell loop. The failing run's saved DOM shows the Run approval button and no started background process. Approve that command through the UI before asserting the existing background/unread transitions; production approval behavior and the original assertions remain intact.
Visual evidence now uses the existing native Actions artifact links (14-day retention), removing the browser-session-cookie attachment publisher and its implementation-specific tests. Screenshots, traces, visual diffs, and the small selected-evidence bundle remain uploaded and linked in the review status.
Validation: desktop renderer/Electron/E2E TypeScript checks passed; Ruff passed; scripts/run_tests.sh tests/ci/test_e2e_screenshot_status.py passed both tests. Full desktop E2E will run in CI: local TrueNAS lacks the native node-pty build toolchain.