feat: implement authorization checks for group member management#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #84
PR Summary
Title
Enhance AutoShare access control and add on-chain authorization failure event
Summary
This PR tightens permissions in the
AutoShareSoroban contract by preventing unauthorized accounts from modifying group membership. It adds an explicitAuthorizationFailureevent, improves admin permission checks, and updates the contract interface and tests to support the new authorization flow.Why
The contract previously allowed
add_group_memberto be called without verifying that the caller was the group creator, creating an access control gap. This PR ensures unauthorized actions revert cleanly and adds on-chain telemetry for authorization failures.Key Changes
AuthorizationFailureevent type incontract/contracts/hello-world/src/base/events.rspublish_authorization_failurehelper inautoshare_logic.rsrequire_adminto publish a failure event and returnUnauthorizedadd_group_memberincontract/contracts/hello-world/src/autoshare_logic.rscontract/contracts/hello-world/src/lib.rscontract/contracts/hello-world/src/interfaces/autoshare.rscontract/contracts/hello-world/src/tests/autoshare_test.rsandcontract/contracts/hello-world/src/tests/pause_test.rsFiles Changed
contract/contracts/hello-world/src/base/events.rscontract/contracts/hello-world/src/autoshare_logic.rscontract/contracts/hello-world/src/lib.rscontract/contracts/hello-world/src/interfaces/autoshare.rscontract/contracts/hello-world/src/tests/autoshare_test.rscontract/contracts/hello-world/src/tests/pause_test.rsTesting
cargo testincontract/contracts/hello-world95 passedNotes