fix(listener): resolve notification count mismatch and optimize stale…#167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #135
I have successfully resolved the notification count mismatch bug. Here is a summary of the accomplishments:
Updated Statistics Calculation: In
scheduled-notification-repository.ts
, updated the SQL queries in getStats() to dynamically classify stale PROCESSING notifications (with expired locks) as pending (and overdue if past execution time) instead of processing.
Updated Stale Lock Recovery: In
scheduled-notification-repository.ts
, modified recoverStaleLocks() to run within a transaction, increment the retry_count for each recovered notification, mark notifications as FAILED once max_retries is reached, and log each recovery attempt to notification_execution_log.
Added Unit Tests: Added three comprehensive tests in
notification-scheduler-refactored.test.ts
to verify retry count incrementation, max-retries limit enforcement on recovery, and statistics count accuracy when stale locks are present.