Open
Conversation
msgilligan
requested changes
Jan 23, 2026
Member
msgilligan
left a comment
msgilligan
left a comment
There was a problem hiding this comment.
I know this is a draft, but I have a couple suggestions
consensusj-jrpc-echod/src/main/java/org/consensusj/jsonrpc/daemon/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
consensusj-jrpc-echod/src/main/java/org/consensusj/jsonrpc/daemon/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
consensusj-jrpc-echod/src/test/java/org/consensusj/jsonrpc/daemon/ApplicationTest.java
Outdated
Show resolved
Hide resolved
msgilligan
reviewed
Jan 23, 2026
consensusj-jrpc-echod/src/main/java/org/consensusj/jsonrpc/daemon/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
Member
|
@liamgilligan See PR #303 |
Member
liamgilligan
force-pushed
the
walletd-help-implementation
branch
from
4b0f436 to
c6e6377
Compare
liamgilligan
force-pushed
the
walletd-help-implementation
branch
from
c6e6377 to
d7729fa
Compare
msgilligan
requested changes
Feb 5, 2026
Member
msgilligan
left a comment
msgilligan
left a comment
There was a problem hiding this comment.
A few requested changes...
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/help/JsonRpcHelp.java
Show resolved
Hide resolved
consensusj-jrpc-echod/src/test/java/org/consensusj/jsonrpc/daemon/ApplicationTest.java
Show resolved
Hide resolved
consensusj-jrpc-echod/src/test/java/org/consensusj/jsonrpc/daemon/ApplicationTest.java
Outdated
Show resolved
Hide resolved
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/services/EchoJsonRpcService.java
Show resolved
Hide resolved
liamgilligan
force-pushed
the
walletd-help-implementation
branch
4 times, most recently
from
3f149c6 to
f57f010
Compare
msgilligan
force-pushed
the
walletd-help-implementation
branch
from
f57f010 to
65101e1
Compare
msgilligan
requested changes
Mar 5, 2026
Member
msgilligan
left a comment
msgilligan
left a comment
There was a problem hiding this comment.
Looks good. I have a few requests.
consensusj-jrpc-echod/src/test/java/org/consensusj/jsonrpc/daemon/ApplicationTest.java
Outdated
Show resolved
Hide resolved
consensusj-jrpc-echod/src/test/java/org/consensusj/jsonrpc/daemon/ApplicationTest.java
Outdated
Show resolved
Hide resolved
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/services/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/services/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/services/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/services/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
consensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/services/EchoJsonRpcService.java
Outdated
Show resolved
Hide resolved
Member
|
See also PR #317 which adds a commit on top of this PR. |
liamgilligan
force-pushed
the
walletd-help-implementation
branch
from
65101e1 to
b7b198f
Compare
Added short summary and detailed help text, added and updated tests, and added javadoc and copyright headers when applicable.
liamgilligan
force-pushed
the
walletd-help-implementation
branch
from
b7b198f to
b08f6b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #260
Currently filler text is being used, tests have been written/modified to account for new
helpbehavior.