This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: clear PHP/Vue quality debt on development (phpcs/eslint/stylelint)#1936
Merged
Conversation
The Vue Quality (eslint) and Vue Quality (stylelint) CI jobs failed because @nextcloud/eslint-config and @nextcloud/stylelint-config declare their plugins as peerDependencies, which 'npm ci --legacy-peer-deps' (used by CI) does not install. Declare the required plugins as explicit devDependencies so they are present at lint time: - eslint: @nextcloud/eslint-plugin, eslint-plugin-jsdoc, @babel/eslint-parser, eslint-config-standard, @vue/eslint-config-typescript, eslint-import-resolver-typescript, eslint-import-resolver-exports - stylelint: stylelint-config-recommended-scss, stylelint-config-recommended-vue, postcss-html Both 'npm run lint' and 'npm run stylelint' now exit 0. Also apply phpcbf auto-fixes (173 violations across 29 files) toward the PHP Quality (phpcs) job.
…s in sync The first commit regenerated package-lock.json under --legacy-peer-deps, which left it out of sync for the PR 'Lint Check' job that runs plain 'npm ci'. Regenerate with default peer resolution so the lockfile is valid for both 'npm ci' and 'npm ci --legacy-peer-deps', keeping all required lint plugins present in node_modules under either install mode.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
The 'Features Check' quality job (PR mode) verifies docs/features.json matches the current openspec/specs/ via scripts/extract-features.py --check. Six specs (ai-mcp, entity-management-modals, files-sidebar-tabs, and others) had been added without regenerating the extract. Regenerate so the check passes (45 features).
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ❌ | |||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-26 08:46 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 539/539 | |||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-26 09:13 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 539/539 | |||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-26 09:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears quality debt that has kept the Code Quality workflow red on
development.Vue Quality (eslint) — FIXED
@nextcloud/eslint-configdeclares its plugins (@nextcloud/eslint-plugin,eslint-plugin-jsdoc,@babel/eslint-parser,eslint-config-standard,@vue/eslint-config-typescript, the import resolvers) as peerDependencies. CI installs withnpm ci --legacy-peer-deps, which does not install peer deps, so eslint crashed with "couldn't find the plugin". Declared them as explicitdevDependencies.npm run lintnow exits 0.Vue Quality (stylelint) — FIXED
Same root cause:
@nextcloud/stylelint-configpeer-depends onstylelint-config-recommended-scss,stylelint-config-recommended-vue, and needspostcss-htmlfor Vue SFC parsing. Declared them as devDeps.npm run stylelintnow exits 0.Lockfile
Regenerated
package-lock.jsonso it is valid under bothnpm ci(PR "Lint Check" job) andnpm ci --legacy-peer-deps(Code Quality job); all required lint plugins resolve under either install mode.PHP Quality (phpcs) — partial
Applied
phpcbfauto-fixes (173 violations across 29 files). Remaining errors are a separate, large mechanical effort (see PR discussion); the dominant rule isSquiz.PHP.DisallowInlineIf.Verification (local)
npm ci-> ok;npm ci --legacy-peer-deps-> oknpm run lint-> exit 0 (0 errors)npm run stylelint-> exit 0php -lclean on all phpcbf-touched files