This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(notifications): schema-driven notification engine + field-change condition#1921
Merged
Merged
Conversation
… condition Lands the OpenRegister notification engine that the fleet apps consume: - Rules sourced ONLY from the schema annotation x-openregister-notifications, evaluated at dispatch from the already-loaded schema (no rule table). - Override-only per-user preferences via Nextcloud user-config (NotificationPreferenceService + NotificationPreferencesController: GET/PUT /api/notification-preferences); absence falls through to the schema default (zero-migration). - AnnotationNotifier renders object_created/object_updated/object_transitioned with nl/en i18n + object-detail action link; Notifier keeps configuration_update_available (mutually exclusive by subject). - Per-recipient delivery gate (schema-default merged with user override). - updated trigger gains an optional non-numeric field-change condition (changed / equals (+from)), fail-closed when old/new data absent, back-compatible for condition-less rules. - Deprecates the NotificationSubscription table/controller with a one-shot idempotent repair migrating rows to user-config overrides. Includes the archived notificatie-engine delta sync, the notification-updated-field-change-condition change, and a queued openregister-system-notifications change request.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 539/539 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 23:32 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the OpenRegister notification engine the fleet apps consume (pipelinq #559, procest #610, nextcloud-vue #446 are already merged against this API).
What
x-openregister-notifications), evaluated at dispatch from the already-loaded schema — no rule table.NotificationPreferenceService+NotificationPreferencesController(GET/PUT /api/notification-preferences). Absence falls through to the schema default (zero-migration).object_created/object_updated/object_transitioned(nl/en + object-detail action link);Notifierkeepsconfiguration_update_available(mutually exclusive by subject so the manager never double-renders).updatedtrigger field-change condition (changed/equals(+optionalfrom)) — fail-closed when old/new data absent, back-compatible for condition-less rules. Unblocks status/assignee-change rules across the fleet.NotificationSubscriptiontable/controller + one-shot idempotent repair migrating rows to user-config.Verification
--strict.Carries the archived
notificatie-enginedelta sync, thenotification-updated-field-change-conditionchange, and a queuedopenregister-system-notificationschange request. Part of the fleet notification rollout (hydra/openspec/fleet-notification-plan.md).🤖 Generated with Claude Code