This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: reverse-spec deep-link-registration (2 REQs / 1 method, new capability)#142
Merged
rubenvdlinde merged 4 commits intoMay 25, 2026
Conversation
…rationListener Drafts 2 REQs (REQ-OBDL-001..002) in a new deep-link-registration capability spec covering the DeepLinkRegistrationListener wiring + handle() method (Bucket 2b from the 2026-05-24 coverage scan). Adds 2 @SPEC tags to the listener's file docblock. REQ-OBDL-001: Event listener wired at app registration - codifies the IRegistrationContext::registerEventListener wiring and the short-circuit on non-matching events. Includes the no-hard-dependency invariant: if OR isn't installed, the listener never fires. REQ-OBDL-002: Per-schema deep-link entries registered against the event - codifies the additive $event->register(appId, registerSlug, schemaSlug, urlTemplate) shape and the {uuid} placeholder. Notes block flags the placeholder schema slug 'example' (scaffold leftover) as TODO - real OpenBuilt schemas (application, application-version, built-app-route) have no deep-link entries yet. Future PRs will extend REQ-OBDL-002 with one register() call per OpenBuilt-owned schema. Refs #137
Creates openspec/specs/deep-link-registration/spec.md (new capability) from the change's spec delta and archives the change. No code logic changes. Refs #137
rubenvdlinde
added
yolo
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 18:36 UTC
Download the full PDF report from the workflow artifacts.
…se-spec-openbuilt-deep-link-registration-2026-05-24 # Conflicts: # .git-blame-ignore-revs
rubenvdlinde
deleted the
retrofit/reverse-spec-openbuilt-deep-link-registration-2026-05-24
branch
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 08:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec
Describes observed behaviour of 1 method
(
DeepLinkRegistrationListener::handle, plus its wiring inApplication::register) as 2 REQs in a brand-new capability specdeep-link-registration.Ghost change:
retrofit-2026-05-24-deep-link-registration(archived).What this PR does
openspec/specs/deep-link-registration/spec.md(retrofit: truefrontmatter) covering the listener wiring + handle() contracttasks.mdwith one[x]task per REQDeepLinkRegistrationListener.phpdocblock with 2 new@spectags (also fills in the missing SPDX would have been nicebut stayed out of scope — annotations only)
REQs
Application::register(wiring),DeepLinkRegistrationListener::handle(short-circuit)DeepLinkRegistrationListener::handle(payload)What this PR does NOT do
examplewith the realOpenBuilt schemas (
application,application-version,built-app-route). Flagged as TODO in REQ-OBDL-002's Note block;separate follow-up PR will extend REQ-OBDL-002 with one
$event->register(...)scenario per OpenBuilt-owned schema.Review focus
feel like over-splitting for one method?
"OR is optional" posture
via Note block, not silently spec'd as production behaviour
Source:
openspec/coverage-report.md(Bucket 2b) generated 2026-05-24 | Cluster:deep-link-registration| Refs #137