Repository navigation
Badge: key verifyUrl on tokenAddressBase58, not the account - #1512
Merged
ktconcordium merged 1 commit intoJul 14, 2026
Merged
Conversation
ktconcordium
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the
verification.verifyUrlexample in the Concordium Badge to key on the badge'stokenAddressBase58, not the owneraccount:Why
A verifier reading a card holds the badge itself — the token address is right there in the
concordiumblock. KeyingverifyUrlon the account made it (a) require pullingowner.accountout first, and (b) return a list of the account's badges rather than a verdict for this one. Keying on the token address means oneGET→ one verdict for the exact badge in hand, which is the whole point of a self-resolving badge.The hosted resolver's
/v1/badge-check/:idaccepts either form (account → all its badges; token address → that one badge), told apart by the base58 version byte, so nothing else changes.🤖 Generated with Claude Code