Skip to content

fix(lcms): fit the three-graph stack, toolbar and panel to their container #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PiTrem merged 6 commits into from
Aug 26, 2026
Merged

fix(lcms): fit the three-graph stack, toolbar and panel to their container #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52de775
fix(lcms): expose stable DOM hooks and stop the LC/MS stack collapsing
PiTrem Aug 25, 2026
0156c75
fix(panel): make the info/multiplicity panel a real scroll container
PiTrem Aug 25, 2026
99023c4
fix(lcms): even out the three pane heights, and harden the hook contract
PiTrem Aug 25, 2026
a4f1eb1
fix(lint): wrap the editor-root className call to satisfy max-len
PiTrem Aug 25, 2026
d7a005b
fix(lcms): fill the pane width, and put the m/z threshold with the ot…
PiTrem Aug 26, 2026
11ac083
fix(lcms): defer the resize remount, and keep the m/z scan across it
PiTrem Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dist/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ Object.defineProperty(exports, "FN", {
return _fn.default;
}
});
Object.defineProperty(exports, "LIST_HOST_HOOK_CLASS", {
enumerable: true,
get: function get() {
return _list_graph.LIST_HOST_HOOK_CLASS;
}
});
exports.store = exports.SpectraEditor = void 0;
var _react = _interopRequireDefault(require("react"));
var _reactRedux = require("react-redux");
Expand All @@ -22,6 +28,7 @@ var _index = _interopRequireDefault(require("./reducers/index"));
var _index2 = _interopRequireDefault(require("./sagas/index"));
var _layer_init = _interopRequireDefault(require("./layer_init"));
var _fn = _interopRequireDefault(require("./fn"));
var _list_graph = require("./constants/list_graph");
var _jsxRuntime = require("react/jsx-runtime");
/* eslint-disable react/function-component-definition, react/require-default-props */

Expand Down
7 changes: 7 additions & 0 deletions dist/components/cmd_bar/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ MuButton.displayName = 'MuButton';
const commonStyle = exports.commonStyle = {
card: {
margin: '0 0 5px 52px',
// The outlined selects below (Submit, Write Peaks, Write Intensity, Decimal) are
// compressed to `selectInput.height = 30`, well under MUI's outlined geometry, so
// their shrunk InputLabel floats to about -9px - outside this box. Without the
// padding it only rendered because nothing above clipped; a host that bounds the
// editor with `overflow: hidden` truncates the labels. Reserve the room here so it
// holds for any host.
paddingTop: 10,
border: '1px solid white',
borderRadius: 4
},
Expand Down
5 changes: 3 additions & 2 deletions dist/components/cmd_bar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var _r08_change_axes = _interopRequireDefault(require("./r08_change_axes"));
var _r09_detector = _interopRequireDefault(require("./r09_detector"));
var _r10_cv_density = _interopRequireDefault(require("./r10_cv_density"));
var _format = _interopRequireDefault(require("../../helpers/format"));
var _list_graph = require("../../constants/list_graph");
var _jsxRuntime = require("react/jsx-runtime");
/* eslint-disable prefer-object-spread, function-paren-newline,
react/function-component-definition, react/require-default-props */
Expand Down Expand Up @@ -95,7 +96,7 @@ const CmdBar = ({
});
if (prependLcMsToolbar) {
return /*#__PURE__*/(0, _jsxRuntime.jsxs)("div", {
className: `${classes.card} ${classes.cardFlex}`,
className: `${_list_graph.LIST_HOST_HOOK_CLASS.CMD_BAR} ${classes.card} ${classes.cardFlex}`,
children: [/*#__PURE__*/(0, _jsxRuntime.jsx)("div", {
className: classes.lcMsToolbarLeft,
children: prependLcMsToolbar
Expand All @@ -109,7 +110,7 @@ const CmdBar = ({
});
}
return /*#__PURE__*/(0, _jsxRuntime.jsxs)("div", {
className: classes.card,
className: `${_list_graph.LIST_HOST_HOOK_CLASS.CMD_BAR} ${classes.card}`,
children: [hideMainEditTools ? null : /*#__PURE__*/(0, _jsxRuntime.jsxs)(_jsxRuntime.Fragment, {
children: [/*#__PURE__*/(0, _jsxRuntime.jsx)(_viewer.default, {
editorOnly: editorOnly
Expand Down
Loading