Skip to content

Conversation

@Darshan-upadhyay1110
Copy link
Contributor

  • Before this patch keybindings were not working on start slide show presentation
  • we do added event listener with capture phase so the keydown will not get override by other key binding
  • start window needs to have the the top priority for arrow key listeners

This fixes an issue in Firefox where arrow keys would not reliably trigger slide changes when presenting in window mode.

Change-Id: I604c1df0ace918d4bda4877390e92837b9b058d9

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

- Before this patch keybindings were not working on start slide show presentation
- we do added event listener with capture phase so the `keydown` will not get override by  other key binding
- start window needs to have the the top priority for arrow key listeners

This fixes an issue in Firefox where arrow keys would not reliably
trigger slide changes when presenting in window mode.

Signed-off-by: Darshan-upadhyay1110 <[email protected]>
Change-Id: I604c1df0ace918d4bda4877390e92837b9b058d9
Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works but I have other question: where is slideshow navigation panel with buttons on Firefox? :)
Possibly that is our root cause of that bug? (so global handler is better, but still we should fix visibility of a navigation panel)
Screenshot From 2026-01-02 16-28-10

@Darshan-upadhyay1110
Copy link
Contributor Author

it works but I have other question: where is slideshow navigation panel with buttons on Firefox? :) Possibly that is our root cause of that bug? (so global handler is better, but still we should fix visibility of a navigation panel) Screenshot From 2026-01-02 16-28-10

Hi @eszkadev, the panel is present, but there is a timeout. After a period of inactivity, it gets hidden automatically. This behavior is the same in Chrome as well, so it is likely not specific to this case.

Screencast.from.2026-01-05.10-20-52.webm

@eszkadev
Copy link
Contributor

eszkadev commented Jan 5, 2026

it works but I have other question: where is slideshow navigation panel with buttons on Firefox? :) Possibly that is our root cause of that bug? (so global handler is better, but still we should fix visibility of a navigation panel)

Hi @eszkadev, the panel is present, but there is a timeout. After a period of inactivity, it gets hidden automatically. This behavior is the same in Chrome as well, so it is likely not specific to this case.

I know about timeout. But in my case it was never appearing

@Darshan-upadhyay1110
Copy link
Contributor Author

it works but I have other question: where is slideshow navigation panel with buttons on Firefox? :) Possibly that is our root cause of that bug? (so global handler is better, but still we should fix visibility of a navigation panel)

Hi @eszkadev, the panel is present, but there is a timeout. After a period of inactivity, it gets hidden automatically. This behavior is the same in Chrome as well, so it is likely not specific to this case.

I know about timeout. But in my case it was never appearing

that is strange let me try to reproduce that. I can see the options on start in window slide show...

@Darshan-upadhyay1110
Copy link
Contributor Author

@eszkadev it's working good in my case. Did tested with many files and 2 different browsers...

@eszkadev
Copy link
Contributor

eszkadev commented Jan 5, 2026

ok, it was by configuration: I used HTTP integrator server and HTTPS-only mode in FF. After allowing HTTP it worked fine and it's unrelated to this PR. thanks, and sorry for noise :)

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Jan 5, 2026
@eszkadev eszkadev merged commit c23a394 into main Jan 5, 2026
15 checks passed
@eszkadev eszkadev deleted the private/darshan/fix-keybinding-for-start-in-window branch January 5, 2026 07:05
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Jan 5, 2026
@Darshan-upadhyay1110 Darshan-upadhyay1110 mentioned this pull request Jan 6, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants