-
Notifications
You must be signed in to change notification settings - Fork 953
Fix keybinding issue for FF #13944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keybinding issue for FF #13944
Conversation
- Before this patch keybindings were not working on start slide show presentation - we do added event listener with capture phase so the `keydown` will not get override by other key binding - start window needs to have the the top priority for arrow key listeners This fixes an issue in Firefox where arrow keys would not reliably trigger slide changes when presenting in window mode. Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I604c1df0ace918d4bda4877390e92837b9b058d9
eszkadev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eszkadev, the panel is present, but there is a timeout. After a period of inactivity, it gets hidden automatically. This behavior is the same in Chrome as well, so it is likely not specific to this case. Screencast.from.2026-01-05.10-20-52.webm |
I know about timeout. But in my case it was never appearing |
that is strange let me try to reproduce that. I can see the options on start in window slide show... |
|
@eszkadev it's working good in my case. Did tested with many files and 2 different browsers... |
|
ok, it was by configuration: I used HTTP integrator server and HTTPS-only mode in FF. After allowing HTTP it worked fine and it's unrelated to this PR. thanks, and sorry for noise :) |


keydownwill not get override by other key bindingThis fixes an issue in Firefox where arrow keys would not reliably trigger slide changes when presenting in window mode.
Change-Id: I604c1df0ace918d4bda4877390e92837b9b058d9
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay