Expose settings dialog in coda #13937
Open
+540
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Ibce2d120ffd1675d2801a31538c91d733cccc617
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I1d762dd8fed78aaab0094843a5e388e7aa52d2d3
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I15e5dc65a5a7ee4b3e365d9d13ed1417ed6b09d3
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I587db3002242356112f6541c3feda2f67fb29bbc
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Iae5ca1724380cb823725206a46787941eaa04984
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I8ea52d54a3e8316dfbbf0cbbc30840dcfbffbb8e
- This change replaces the redundant check-box svg logic with actual input check-box Change-Id: Ifd17fcea76770c1a6a27c6df2dac877a5134f915 Signed-off-by: Parth Raiyani <[email protected]>
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Ia606c42771fab9fe8a09ceb888ee37e19f93ed5a
Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I390c6a1e17f9c2414e885c36e1e042157217aaec
|
thanks for this PR! |
timar
requested changes
Jan 3, 2026
| COOL_IMAGES_CUSTOM_SRC = $(shell if test -n "$(CUSTOM_ICONS_DIRECTORY)"; then find $(CUSTOM_ICONS_DIRECTORY) -name '*.*'; fi) | ||
| COOL_IMAGES_CUSTOM_DST = $(patsubst $(CUSTOM_ICONS_DIRECTORY)/%,$(DIST_FOLDER)/images/%,$(COOL_IMAGES_CUSTOM_SRC)) | ||
| COOL_L10N_SRC = $(shell find $(srcdir)/l10n -name '*.json') | ||
| if !ENABLE_MOBILEAPP |
Member
There was a problem hiding this comment.
This does not look good. In apps (mobile apps and desktop apps) l10n.js does not work. We have to bundle and load all translations at startup.
github-project-automation
bot
moved this from To Review
to In Progress
in Collabora Online
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay