jsdialog: dropdown conversion to ts #13908
Open
+300
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I1b78a06bbeb004041389692a66823784cdb87814
eszkadev
force-pushed
the
private/eszkadev/jsdialog-dropdown-ts
branch
from
4991858 to
4d3ea5e
Compare
- renamed Util.Dropdown from .js to .ts - added missing types - strict checking helps to prevent mistakes when using dropdown which is used in many contexts (combobox, menubutton, standalone menus, submenus), followup for #13903 Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Idc374a1fef73cc8d02cf165d259077df2a2f1c2b
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Ie0d539bd756d006d0c565c25d2ba38216f422005
eszkadev
force-pushed
the
private/eszkadev/jsdialog-dropdown-ts
branch
from
4d3ea5e to
2b0b939
Compare
Member
dennisfrancis
left a comment
dennisfrancis
left a comment
There was a problem hiding this comment.
I left one comment in the second patch. Other than that the changes look fine to me.
| let pos = -1; | ||
| if (typeof data === 'number') pos = data; | ||
| else pos = data ? parseInt(data.substr(0, data.indexOf(';'))) : -1; | ||
| const entry = targetEntries && pos !== null ? targetEntries[pos] : null; |
Member
There was a problem hiding this comment.
Shouldn't it be pos !== -1 as pos is now only a number ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helps to prevent mistakes when using dropdown which is used in many contexts (combobox, menubutton, standalone menus, submenus), followup for #13903