Allow to run the coda-qt from out-of-tree build and in-tree-build alike + fix out-of-tree build #13896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fridrich Štrba <[email protected]> Change-Id: Ifc050bff24ada2bd9b70997d11156e4fd23b5b19
Signed-off-by: Fridrich Štrba <[email protected]> Change-Id: Id10d1a8584115b442a55399264524eaf8d66e5ad
Darshan-upadhyay1110
requested review from
hfiguiere and
stbergmann
and removed request for
hfiguiere
stbergmann
merged commit 5a55030
into
CollaboraOnline:private/sberg/20251219-1
2 checks passed
|
Thanks a lot for your contribution, and congrats on your first pull request merged! Welcome aboard! 🎉🎉🎉 If you haven't decided on your next task yet, take a look at our easy-hacks. We're looking forward to your next pull request! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay