perf(note-list): virtualize with react-virtuoso#795
Open
CodyTseng wants to merge 1 commit into
Open
Conversation
Replace the render-all-items + IntersectionScroll pagination with react-virtuoso. Add ScrollAreaProvider so NoteList can pick the right scroll mode: useWindowScroll on mobile (preserves browser-chrome auto- hide) vs customScrollParent on desktop (uses the existing Radix ScrollArea viewport). Tune Virtuoso with overscan=1000, increaseViewportBy=1000, and skipAnimationFrameInResizeObserver so scroll-position compensation happens in the same frame as the size change — eliminates the back-scroll jitter caused by variable-height items loading async (same config YakiHonne uses). Also drops the IntersectionObserver-based reveal logic from EmbeddedNote; virtualization handles offscreen items now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoteListwithreact-virtuoso.ScrollAreaProviderso the list picks the right scroll mode:useWindowScrollon mobile (preserves the browser-chrome auto-hide behavior) vscustomScrollParenton desktop (uses the existing RadixScrollAreaviewport).overscan=1000,increaseViewportBy=1000, andskipAnimationFrameInResizeObserver— keeps scroll-position compensation synchronous with size changes, eliminating the back-scroll jitter from variable-height items loading async (matches the config YakiHonne uses).IntersectionObserver-based reveal logic inEmbeddedNote; virtualization handles offscreen items now.Test plan
PrimaryPageLayout/SecondaryPageLayoutis smooth.scrollToTop&refreshimperative APIs still work.🤖 Generated with Claude Code