fix(help): enforce recommendation ownership check on sendHelpRequest #804
Open
Shriraj888 wants to merge 1 commit into
Open
fix(help): enforce recommendation ownership check on sendHelpRequest #804Shriraj888 wants to merge 1 commit into
Shriraj888 wants to merge 1 commit into
Conversation
…d Inngest dispatch
Contributor
|
@Shriraj888 is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Shriraj888
changed the title
Author
|
@Ayush4958 Could you please review this PR when you get a chance? Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces recommendation ownership in
sendHelpRequestbefore allowing contributors to create a help request or trigger Inngest help dispatch notifications.Type of Change
Related Issue
Closes #794
What was changed?
sendHelpRequest(src/app/actions/help.ts) prior to processing cooldown and insert.not_foundif recommendation does not exist, andforbiddenif it does not belong to the signed-in user (rec.user_id !== user.id).recommendation_idon thehelp_requestsinsert row for triage traceability back to the recommended work.src/app/actions/help.test.tscovering missing, foreign, and ownedrecIdscenarios.Screenshots
N/A (Backend API / Server Action update)
Checklist
npm run dev)