fix(inngest): log error and throw on repo discovery failure to enable retries#792
Open
yush-1018 wants to merge 1 commit into
Open
fix(inngest): log error and throw on repo discovery failure to enable retries#792yush-1018 wants to merge 1 commit into
yush-1018 wants to merge 1 commit into
Conversation
Contributor
|
@yush-1018 is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
yush-1018
force-pushed
the
fix/repo-discovery-silent-failure
branch
from
July 24, 2026 14:54
0ed4cf9 to
2d66157
Compare
Collaborator
|
PR Review :- Functionality :- Correctly logs and throws an error instead of failing silently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an issue where temporary GitHub API failures during repo discovery (e.g. when installing the GitHub App with "All repositories" selected) caused the installation to silently fail and leave
installation_repositoriesempty permanently.Changes Made
process-installation-event.tsto log errors usingconsole.errorwith installation context and re-throw anErrorwhengetInstallOctokitor paginate calls fail. This allows Inngest to automatically retry the step with exponential backoff.process-installation-event.test.tsverifying that repo discovery works via API fallback and that errors are caught and thrown for retries.Quality Control
npm run lint(eslint src) passed with 0 errors and 0 warnings.process-installation-event.test.tspass cleanly.#791