Skip to content

feat(my-prs): add Needs Changes tab and mentor feedback display - #790

Merged
jakharmonika364 merged 2 commits into
Coder-s-OG-s:mainfrom
Tirthpanchori:feat/my-prs-redesign
Jul 26, 2026
Merged

feat(my-prs): add Needs Changes tab and mentor feedback display#790
jakharmonika364 merged 2 commits into
Coder-s-OG-s:mainfrom
Tirthpanchori:feat/my-prs-redesign

Conversation

@Tirthpanchori

@Tirthpanchori Tirthpanchori commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a NEEDS CHANGES tab to /my-prs, with a matching status badge, action
button, and inline mentor-feedback text, so contributors can see when a mentor
has requested changes on an open PR — previously this state had no visibility
on this page at all.

Type of Change

  • Bug fix
  • New feature
  • UI / UX improvement
  • Refactor
  • Documentation
  • Other

Related Issue

Closes #677

What was changed?

  • Added changes_requested + review_feedback to the EnrichedPR type (page.tsx, pr-list.tsx)
  • page.tsx: query pull_request_pipeline_stages + pull_request_reviews.body_excerpt, layer on top of the existing recommendations/help_requests logic as a higher-priority signal (fresher, comes from GitHub review webhooks directly)
  • pr-list.tsx: new NEEDS CHANGES tab/filter/count, new badge + action button states, inline feedback quote block
  • Existing mentor_status logic untouched — added to, not replaced, per maintainer guidance to keep this a single PR with no backend changes

Known limitation (not fixed here): recommendations/help_requests and pipeline_stages aren't cross-written anywhere in the codebase, so these two review-status signals can theoretically drift. Flagging for visibility, not expanding scope here.

Also noticed, not touched: PRMeta double-renders +{xp_earned} XP earned for merged PRs with XP set — pre-existing, unrelated bug.

Screenshots

image

Checklist

  • My code follows the project structure and conventions
  • I tested this locally (npm run dev)
  • No hardcoded secrets or credentials
  • I have updated documentation if needed

Driven by pull_request_pipeline_stages (changes_requested), layered on
top of existing mentor_status logic. Closes Coder-s-OG-s#677
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@Tirthpanchori is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel.

A member of the Team first needs to authorize it.

@pavsoss pavsoss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation LGTM, just one edge case bug:
the Needs Changes filter/count needs the same state === 'open' guard as pending_review, otherwise the drift the author flagged leaks stale merged/closed PRs into the tab

@pavsoss pavsoss added the Needs author reply Author need to reply label Jul 25, 2026
@Tirthpanchori

Copy link
Copy Markdown
Contributor Author

Good catch - fixed in the latest commit. Added the same state === 'open' guard to the needs_changes filter and count that pending_review already had. getPRStatusInfo itself was already safe (checks merged/closed before
changes_requested), so this was isolated to the tab filter/count logic in PRList.

@jakharmonika364 jakharmonika364 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakharmonika364 jakharmonika364 added level:advanced Advanced level difficulty quality:clean Clean, well-structured contribution type:feature New feature gssoc:approved Approved by GSSOC admin SSoC26 Hard ECSoC26 ECSoC26-L3 Hard good-pr and removed Needs author reply Author need to reply labels Jul 26, 2026
@jakharmonika364
jakharmonika364 merged commit d0af6d1 into Coder-s-OG-s:main Jul 26, 2026
2 of 3 checks passed
@ecsoc-sentinel ecsoc-sentinel Bot added ECSoC26-L2 Medium and removed ECSoC26-L3 Hard labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26-L2 Medium ECSoC26 good-pr gssoc:approved Approved by GSSOC admin Hard level:advanced Advanced level difficulty quality:clean Clean, well-structured contribution SSoC26 type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Implement Pull Requests tracking page (My PRs)

3 participants