feat(my-prs): add Needs Changes tab and mentor feedback display - #790
Merged
jakharmonika364 merged 2 commits intoJul 26, 2026
Merged
Conversation
Driven by pull_request_pipeline_stages (changes_requested), layered on top of existing mentor_status logic. Closes Coder-s-OG-s#677
Contributor
|
@Tirthpanchori is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
pavsoss
suggested changes
Jul 25, 2026
pavsoss
left a comment
Collaborator
There was a problem hiding this comment.
The implementation LGTM, just one edge case bug:
the Needs Changes filter/count needs the same state === 'open' guard as pending_review, otherwise the drift the author flagged leaks stale merged/closed PRs into the tab
Contributor
Author
|
Good catch - fixed in the latest commit. Added the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
NEEDS CHANGEStab to/my-prs, with a matching status badge, actionbutton, and inline mentor-feedback text, so contributors can see when a mentor
has requested changes on an open PR — previously this state had no visibility
on this page at all.
Type of Change
Related Issue
Closes #677
What was changed?
changes_requested+review_feedbackto theEnrichedPRtype (page.tsx,pr-list.tsx)page.tsx: querypull_request_pipeline_stages+pull_request_reviews.body_excerpt, layer on top of the existingrecommendations/help_requestslogic as a higher-priority signal (fresher, comes from GitHub review webhooks directly)pr-list.tsx: newNEEDS CHANGEStab/filter/count, new badge + action button states, inline feedback quote blockmentor_statuslogic untouched — added to, not replaced, per maintainer guidance to keep this a single PR with no backend changesKnown limitation (not fixed here):
recommendations/help_requestsandpipeline_stagesaren't cross-written anywhere in the codebase, so these two review-status signals can theoretically drift. Flagging for visibility, not expanding scope here.Also noticed, not touched:
PRMetadouble-renders+{xp_earned} XP earnedfor merged PRs with XP set — pre-existing, unrelated bug.Screenshots
Checklist
npm run dev)