fix(i18n): restore complete English fallback strings - #2171
Conversation
PR Validation ResultsChange Detection
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe English translation catalog now contains complete messages, examples, and interpolation placeholders. An obsolete top-level entry was removed. An inline fallback comment now documents the current translation convention. ChangesLocalization corrections
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change restores complete English validation, help, and status messages and removes an accidental locale entry. No actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same truncation-at-apostrophe signature as the rest of this PR: - settings.passkey.description - cycle.ttc.testLogsHistory - pregnancy.checklist.title Each restored verbatim from its inline t() fallback in source.
Description
What problem does this PR solve?
Eleven English locale values were truncated during the recent translation-key backfill, and a source-comment example created one accidental locale key. Users could therefore see incomplete validation, help, and status messages.
How did you implement the solution?
Restored the complete English fallback strings and interpolation placeholders from their source usage, removed the false-positive locale entry, and reworded the comment so the coverage scan no longer treats it as application code.
Linked Issue: N/A — no existing issue; the malformed values were introduced by the recent translation-key backfill.
Related translation update: CodeWithCJ/SparkyFitnessTranslations#15
How to Test
SparkyFitnessFrontend, runpnpm run validate.pnpm exec jest src/tests/utils/translationKeysCoverage.test.ts --runInBand.keylocale entry is absent.PR Type
Checklist
All PRs:
New features only:
Frontend changes (
SparkyFitnessFrontend/):pnpm run validateand it passes.en) translation file.Backend changes (
SparkyFitnessServer/):rls_policies.sqlfor any new user-specific tables.UI changes (components, screens, pages):
Mobile changes (
SparkyFitnessMobile/):Screenshots
Not applicable. The TypeScript change only rewords a source comment; the runtime changes restore complete text in the English locale catalog.
Notes for Reviewers
The repeated truncation at apostrophes and embedded quotes indicates an escaping/parsing issue in the earlier bulk key extraction. This PR is intentionally limited to the English reference locale; non-English locales remain owned by the translation sync workflow.
Validation completed successfully on commit
3ac0c9c:pnpm run validatepnpm exec jest src/tests/utils/translationKeysCoverage.test.ts --runInBandgit diff --checkSummary by CodeRabbit
Bug Fixes
Documentation