mctp-usb: Simply return the header in MctpUsbHandler::header()#46
mctp-usb: Simply return the header in MctpUsbHandler::header()#46SafetyInObscurity wants to merge 1 commit intoCodeConstruct:mainfrom
Conversation
|
Looks good! The CI failure looks like a general thing from the nightly toolchain, which we may want to address separately. The change itself looks good, I would suggest a couple of things on the commit message though:
I'd suggest a prefix on this, as you have done in the PR. Since we're modifying multiple crates, perhaps I'd also suggest some more context in the commit message; for example, why would it be better, and what effects would this have on the public API? (are there users of |
I have a pending change here to remove nightly toolchain from the PR CI job, and run it separately on a timer. I'll push that soon as a separate PR. |
SafetyInObscurity
force-pushed
the
return-type
branch
from
f26ee55 to
d82c284
Compare
Current implementation takes destination variable as a mutable argument and modifies it. It would be better for the function to simply return the header, rather than an empty `Ok(())` on success. This breaks the current API for header(), but adjustment should be simple. Signed-off-by: James Lee <james@codeconstruct.com.au>
SafetyInObscurity
force-pushed
the
return-type
branch
from
d82c284 to
4110369
Compare
3 participants
Current implementation takes destination variable as a mutable argument and modifies it. It would be better for the function to simply return the header, rather than an empty
Ok(())on success.