Allow cloaked units under player control to have SELECT cursor on it when about to select#20
Open
chaserli wants to merge 1 commit intoCnCNet:mainfrom
Open
Allow cloaked units under player control to have SELECT cursor on it when about to select#20chaserli wants to merge 1 commit intoCnCNet:mainfrom
chaserli wants to merge 1 commit intoCnCNet:mainfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Member
|
@chaserli If you don't mind, I'll get back to this PR in a couple of weeks. There are a few other things I'm busy with right now |
Member
Author
b0af8ba to
dbcfd07
Compare
e0f9764 to
916afee
Compare
63f72f4 to
fd36e64
Compare
946337e to
b97a815
Compare
b97a815 to
8c1b515
Compare
887ea7c to
adfdfed
Compare
chaserli
added a commit
to chaserli/CNCNet_dll
that referenced
this pull request
May 30, 2025
…when about to select Co-Authored-By: Trsdy <9932846+chaserli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically at this point it's useless to do all these checks.
What had the program done?
This is the very end of that function it's not sufficient to only let "me" select
pObjectif it belongs tothis->Ownerwhich is known to be controlled by me. It is also possible that "I" (the controller ofthis) can only control the owning house ofpObjectbut is not it. In that case you gotta let me select it too