Remove default page size - #540
Merged
Merged
Conversation
|
Coverage is 88.411% — remove-default-page-size into master. No base build found for |
|
Coverage is 88.411% — remove-default-page-size into master. No base build found for |
|
Contributor
Author
Test
The total is the same as the number of analyses in the response. |
Contributor
Author
|
I have checked CG, Cigrid-UI, and Clinical-genomics-ui for potential issues with removing the default page size. I have not found any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The analyses GET endpoint had a default page size (250), which could mislead callers into thinking a capped response was the full result set. To remove that confusion, the default
pageSizehas been removed — ifpageSizeis omitted, all matching analyses are now returned instead of being capped at 250.Changed
pageSizenow returns all matching analyses instead of the first 250.How to prepare for test
uspaxabash /home/proj/production/servers/resources/clinical-db.scilifelab.se/update-trailblazer-ui-stage.sh remove-default-page-sizeHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a