Skip to content

Adjust nallo deliverable requirements for NBS - #171

Draft
ieduba wants to merge 8 commits into
mainfrom
nbs-nallo
Draft

Adjust nallo deliverable requirements for NBS#171
ieduba wants to merge 8 commits into
mainfrom
nbs-nallo

Conversation

@ieduba

@ieduba ieduba commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

When we run nallo for newborn screening cases for CMMS, we will skip many workflows and produce many fewer files. In order to be able to store the results on housekeeper, we need to make the missing files non-mandatory.

Added

Changed

  • Made output files from phasing, methylation, peddy, repeat calling, and (most) SV calling non-mandatory

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy <branch-name>
hermes-test <command here>

How to test

  • login to ...
  • do ...

Expected test result

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (4a6315e) to head (41f19d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          28       28           
  Lines        1030     1030           
=======================================
  Hits          957      957           
  Misses         73       73           
Flag Coverage Δ
unittests 92.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ieduba ieduba changed the title Make methylation, peddy, and repeats optional in nallo Adjust nallo deliverable requirements for NBS Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants