Pool delivered at

[islean]

Description

Closes #5200.

Added

• Column order_id on the Pool table with associated relationship to the Order table

Changed

• Removed ticket column from the Pool table and exchanged it for a property using the now linked order table

Fixed

• The delivered_at in the Pool table is now set when the associated order's samples all have a delivered_at
• The Ordering service now populated the order_id column instead of the ticket column on the Pool table
• The Admin view displays the ticket as a link to the order table.

How to prepare for test

• Ssh to relevant server (depending on type of change)
• Use stage: us
• Paxa the environment: paxa
• Install on stage (example for Hasta):

  bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b pool-delivered-at -a

How to test

• Submit an RML order and make sure it gets persisted correctly.
• Submit a Fluffy order and make sure it gets persisted correctly.
• Make sure the formatting of the Pool table in the admin view is correct (ticket should link to Freshdesk?)
• Make sure that delivering an order delivers the pools.

Expected test outcome

• Check that ...
• Take a screenshot and attach or copy/paste the output.

Review

• Tests executed by
• "Merge and deploy" approved by
  Thanks for filling in who performed the code review and the test!

This version is a

• MAJOR - when you make incompatible API changes
• MINOR - when you add functionality in a backwards compatible manner
• PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

• Document in ...
• Deploy this branch on ...
• Inform to ...

[islean]

Test submitting a Fluffy order with two pools in:

Test submitting an RML order with one pool:

[islean]

Test delivering an order delivers the pool:

[isak.ohlsson@hasta:~] [S_base] $ cg deliver order -t **** -s IO
Running CG deliver
Delivering 1 analyses of ticket ****.
Marking samples as delivered for case ****
Setting analyses [****] as delivered in Trailblazer
Order **** is now closed.
Setting pool **** as delivered.
[isak.ohlsson@hasta:~] [S_base] $ 

And the change is persisted:

[islean]

Upgrade and downgrade successful ✅

[diitaz93]

We can discuss in detail the coments tomorrow if you want

[islean]

New column is not nullable:

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[diitaz93]

Looks great 💯

[islean]

Deployed to Hasta:

INFO  [alembic.runtime.migration] Context impl MySQLImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 7e84083f6cb0 -> eb2e90a251c5, Add order fk to pool
repository is clean
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... done.
Log deploy... done.
cg, version 87.10.2
[isak.ohlsson@hasta:~] [P_base] $ 

And to the VMs