feat(vaapi): per-codec quality preset, default to best on AMD#1515
Open
ryancatlin wants to merge 1 commit into
Open
feat(vaapi): per-codec quality preset, default to best on AMD#1515ryancatlin wants to merge 1 commit into
ryancatlin wants to merge 1 commit into
Conversation
Mesa AMD VAAPI's ffmpeg -quality knob picks the encoder speed/quality preset, where higher = faster. On VCN3+ the slowest preset is well within the per-frame budget even at 4K60, so previously leaving this unset gave a "balanced" default that was unnecessarily lossy for game streaming on capable hardware. - New options: vaapi_h264_quality, vaapi_hevc_quality, vaapi_av1_quality (-1 = driver default; 0 = best on AMD; higher integers progressively faster/lower quality). - When user has not overridden the value AND VAAPI vendor is AMD, default to 0 (best quality) automatically. Other vendors (Intel iHD, etc.) keep their driver default to avoid surprising behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
vaapi_h264_quality,vaapi_hevc_quality,vaapi_av1_qualityconfigoptions mapping to ffmpeg's VAAPI
-qualityknob (the encoder speed/qualitypreset, where higher = faster):
-1= driver default (unchanged behaviour)0= best quality; higher integers = progressively fasterWhy
On AMD VCN the slowest preset is comfortably within the per-frame budget even at
4K, so the driver's "balanced" default is unnecessarily lossy for game streaming
on capable hardware. When the user has not set a value and the VAAPI vendor
is AMD, default to
0(best). Other vendors (Intel iHD, etc.) keep their driverdefault to avoid surprising behaviour changes.
Notes
-1.