Io#62
Merged
Merged
Conversation
Sounds reasonable Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#60
This pull request introduces improvements to command-line argument handling and network rate configuration across multiple modules, making the codebase more consistent and flexible. The most significant changes include centralizing the parsing of simulation constants, expanding support for network link rates, and updating documentation and debug tooling to better handle problem instance ranges.
Command-line argument parsing improvements
parse_command_line_constantsfunction intsnkit/core/_common.py, allowing simulation constants (e.g., slot size, processing delay, queue numbers) to be set via command-line arguments and updating global values incore. This function is now invoked across multiple modules (core,data/generator.py,simulation/tas.py,test/benchmark/__main__.py,test/debug/__main__.py, andtest/debug/_common.py) for consistent configuration. [1] [2] [3] [4] [5] [6] [7]--insargument for specifying ranges of problem instances, with improved parsing and error handling for these ranges. [1] [2] [3]Network rate configuration enhancements
rateparameter frominttofloatintsnkit/core/_network.pyand expanded accepted values to include 0.01 and 0.1, supporting finer-grained bandwidths (10 Mbps, 100 Mbps) in addition to existing rates. [1] [2] [3] [4]Documentation and usage updates
doc/source/simulation.md) to clarify usage of the debug tool, showing how to specify problem instance ranges and single method testing with the new argument format.These changes improve usability, flexibility, and consistency in simulation configuration and debugging workflows.