Skip to content

Simplify Semigroup and MonadFree ActionT instances #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify Semigroup and MonadFree ActionT instances #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/Eve/Internal/Actions.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ module Eve.Internal.Actions
) where

import Eve.Internal.States
import Control.Applicative (liftA2)
import Control.Monad.State
import Control.Monad.Trans.Free
import Control.Lens
Expand All @@ -43,18 +44,15 @@ newtype ActionT base zoomed m a = ActionT
{ getAction :: FreeT (AppF base m) (StateT zoomed m) a
} deriving (Functor, Applicative, Monad, MonadIO, MonadState zoomed)

instance (Semigroup a,Monad m) => Semigroup (ActionT base zoomed m a) where
a <> b = do
a' <- a
b' <- b
return $ a' <> b'
instance (Semigroup a, Monad m) => Semigroup (ActionT base zoomed m a) where
(<>) = liftA2 (<>)

instance (Monoid a, Monad m) => Monoid (ActionT base zoomed m a) where
mempty = return mempty
mappend = (<>)

instance Monad n => MonadFree (AppF base n) (ActionT base zoomed n) where
wrap (RunApp act) = join . ActionT . liftF . RunApp $ act
wrap = join . ActionT . liftF

instance MonadTrans (ActionT base zoomed) where
lift = ActionT . lift . lift
Expand Down Expand Up @@ -88,7 +86,7 @@ runActionOver = zoom

-- | Allows you to run an 'App' inside of an 'Action'
runApp :: Monad m => AppT base m a -> ActionT base zoomed m a
runApp = liftF . RunApp . unLift . getAction
runApp = liftF . RunApp . unLift . getAction

-- | Runs an application and returns the value and state.
runEve :: Monad m => base -> AppT base m a -> m (a, base)
Expand Down