Skip to content

Conversation

@Tsingv
Copy link
Contributor

@Tsingv Tsingv commented Dec 24, 2025

What this PR does

Before this PR: The miniWindow could not popup once closed.

before

After this PR: Expeteced behavior

after

Why we need it and why it was done in this way

The implementation of hideMiniWindow in WindowService.ts invokes app.hide(), which is redundant on macOS. Since the miniWindow is not a standard window, application switching does not occur as expected.

If the miniWindow is displayed after the application is hidden, the focus will automatically shift from the miniWindow to the main window, triggering the blur event and causing both windows to be hidden. As a result, the miniWindow cannot be properly displayed.

Breaking changes

NONE

Special notes for your reviewer

NONE

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@0xfullex
Copy link
Collaborator

0xfullex commented Dec 25, 2025

Note

This comment was translated by Claude.

macOS 26?


Original Content

macOS 26?

@Tsingv
Copy link
Contributor Author

Tsingv commented Dec 25, 2025

Yes, MacOS 26.2. Not verified on other versions.

@EurFelux
Copy link
Collaborator

CI failed

@0xfullex
Copy link
Collaborator

It's possible that the new window behavior in macOS 26 has caused the original hacky code to fail.
The original code worked fine on < OS 26, so a better solution would be to implement version checking, using the new code on OS 26 while keeping the other versions unchanged.

@Tsingv
Copy link
Contributor Author

Tsingv commented Dec 26, 2025

Thank you for the advice. The change now only affects macOS 26 and above, and the CI should be working properly.

@kangfenmao kangfenmao merged commit 2383fd0 into CherryHQ:main Jan 4, 2026
atoz03 pushed a commit to atoz03/cherry-studio that referenced this pull request Jan 4, 2026
fix: resolve unexpected miniwindow loop closure on MacOS 26+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants