[Fix] fix image model initialization and tool ref passing

[dingyi222666]

This pr fixes issues with image model initialization and ensures the image tool correctly references the model.

Bug fixes

• Fix image model initialization logic to use correct config parameter
• Fix imageModelRef passing in ReadImageTool to prevent stale references

Other Changes

• Bump koishi-plugin-chatluna-image-service version to 1.3.4

[gemini-code-assist]

Summary of Changes

Hello @dingyi222666, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and correctness of the image service within the chatluna ecosystem. It refines how image models are initialized and ensures that tools interacting with these models maintain up-to-date references, thereby preventing potential runtime errors and improving overall reliability.

Highlights

• Image Model Initialization: The logic for initializing the image understanding model has been corrected to directly use the config.model parameter, removing an intermediate parsing step.
• Tool Reference Passing: The imageModelRef is now passed as a function returning a ComputedRef to the ReadImageTool, resolving issues with stale references and ensuring the tool always accesses the latest model instance.
• Version Bump: The koishi-plugin-chatluna-image-service package version has been updated from 1.3.3 to 1.3.4.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/service-image/package.json
  • Updated the package version from 1.3.3 to 1.3.4.
• packages/service-image/src/index.ts
  • Removed the import and usage of parseRawModelName, simplifying model initialization.
  • Modified ctx.chatluna.createChatModel to directly accept config.model, streamlining the model creation process.
  • Updated warning messages to reference config.model directly, improving clarity.
  • Removed a redundant logger.debug statement.
• packages/service-image/src/tool.ts
  • Refactored the imageModelRef parameter in the apply function and ReadImageTool constructor to be a function that returns a ComputedRef, ensuring dynamic access to the model.
  • Adjusted the createTool method to pass the imageModelRef as a function, preventing stale closures.
  • Modified the access pattern for the image model within ReadImageTool from this.imageModelRef.value to this.imageModelRef().value to reflect the new functional approach.

Activity

• The pull request was opened by dingyi222666. No further activity such as comments or reviews has been recorded.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses two bugs related to image model handling. The model initialization logic is simplified and corrected by passing the full model name directly to createChatModel. The stale reference issue in ReadImageTool is cleverly resolved by passing a factory function for the model reference, ensuring the tool always accesses the most current model. The changes are solid, and I have one minor suggestion to improve code readability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

简化了模型名称的处理流程，直接使用 config.model 而不再通过 parseRawModelName 解析。同时调整了 ReadImageTool 的初始化方式，改为通过 thunk 函数进行延迟访问计算型引用，保留现有的错误处理机制。

Changes

Cohort / File(s)	Summary
模型引用处理优化 packages/service-image/src/index.ts, packages/service-image/src/tool.ts	移除了 parseRawModelName 解析逻辑，直接使用 config.model。ReadImageTool 改为接收 thunk 函数 (() => ComputedRef<...>) 实现延迟访问，内部通过 this.imageModelRef().value 获取模型，保持现有错误处理流程不变。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• [Feature] Add image reading tool support #710: 主要 PR 涉及 ReadImageTool 构造函数和 apply 调用的相同改动，直接接触到本次变更中引入的工具初始化和模型访问代码。

Poem

🐰 一只兔子闻到代码的香气，
移除繁琐的解析，让引用更敏捷，
Thunk 函数轻轻一跳，延迟访问变巧妙，
模型在指尖舞动，清晰又简洁，
代码的花园里，又添新的优雅。✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/image-service-tool

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}